From ab3f397e2d3f68eddc0cf66b67ff781cbb2e399d Mon Sep 17 00:00:00 2001
From: Paul Gilbert
Date: Sun, 22 Apr 2018 11:44:15 -0400
Subject: TITANIC: Fix memory leak due to save thumbnail changes

---
 engines/titanic/core/project_item.cpp | 4 ++--
 engines/titanic/detection.cpp         | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

(limited to 'engines')

diff --git a/engines/titanic/core/project_item.cpp b/engines/titanic/core/project_item.cpp
index 6da891c417..424562ffef 100644
--- a/engines/titanic/core/project_item.cpp
+++ b/engines/titanic/core/project_item.cpp
@@ -495,7 +495,7 @@ SaveStateList CProjectItem::getSavegameList(const Common::String &target) {
 	return saveList;
 }
 
-bool CProjectItem::readSavegameHeader(SimpleFile *file, TitanicSavegameHeader &header, bool skipThumbnail) {
+bool CProjectItem::readSavegameHeader(SimpleFile *file, TitanicSavegameHeader &header, bool loadThumbnail) {
 	char saveIdentBuffer[SAVEGAME_STR_SIZE + 1];
 	header._thumbnail = nullptr;
 	header._totalFrames = 0;
@@ -518,7 +518,7 @@ bool CProjectItem::readSavegameHeader(SimpleFile *file, TitanicSavegameHeader &h
 	while ((ch = (char)file->readByte()) != '\0') header._saveName += ch;
 
 	// Get the thumbnail
-	if (!Graphics::loadThumbnail(*file, header._thumbnail, skipThumbnail))
+	if (!Graphics::loadThumbnail(*file, header._thumbnail, !loadThumbnail))
 		return false;
 
 	// Read in save date/time
diff --git a/engines/titanic/detection.cpp b/engines/titanic/detection.cpp
index c98fbbdade..07a17ae779 100644
--- a/engines/titanic/detection.cpp
+++ b/engines/titanic/detection.cpp
@@ -156,7 +156,7 @@ SaveStateDescriptor TitanicMetaEngine::querySaveMetaInfos(const char *target, in
 		file.open(f);
 
 		Titanic::TitanicSavegameHeader header;
-		if (!Titanic::CProjectItem::readSavegameHeader(&file, header, false)) {
+		if (!Titanic::CProjectItem::readSavegameHeader(&file, header, true)) {
 			file.close();
 			return SaveStateDescriptor();
 		}
-- 
cgit v1.2.3