From cd271a0b34bc575201bf1d700069a7a3960b45de Mon Sep 17 00:00:00 2001 From: Strangerke Date: Sat, 28 May 2016 18:37:22 +0200 Subject: GNAP: Remove duplicate code in screenEffect --- engines/gnap/gnap.cpp | 23 +++++++++-------------- 1 file changed, 9 insertions(+), 14 deletions(-) (limited to 'engines') diff --git a/engines/gnap/gnap.cpp b/engines/gnap/gnap.cpp index 98f2c01cac..ed2d25f3de 100644 --- a/engines/gnap/gnap.cpp +++ b/engines/gnap/gnap.cpp @@ -946,20 +946,15 @@ void GnapEngine::updateIdleTimer() { } void GnapEngine::screenEffect(int dir, byte r, byte g, byte b) { - if (dir == 1) { - for (int y = 300; y < 600 && !_gameDone; y += 50) { - _gameSys->fillSurface(nullptr, 0, y, 800, 50, r, g, b); - _gameSys->fillSurface(nullptr, 0, 549 - y + 1, 800, 50, r, g, b); - gameUpdateTick(); - _system->delayMillis(50); - } - } else { - for (int y = 0; y < 300 && !_gameDone; y += 50) { - _gameSys->fillSurface(nullptr, 0, y, 800, 50, r, g, b); - _gameSys->fillSurface(nullptr, 0, 549 - y + 1, 800, 50, r, g, b); - gameUpdateTick(); - _system->delayMillis(50); - } + int startVal = 0; + if (dir == 1) + startVal = 300; + + for (int y = startVal; y < startVal + 300 && !_gameDone; y += 50) { + _gameSys->fillSurface(nullptr, 0, y, 800, 50, r, g, b); + _gameSys->fillSurface(nullptr, 0, 549 - y + 1, 800, 50, r, g, b); + gameUpdateTick(); + _system->delayMillis(50); } } -- cgit v1.2.3