From 4d4042df36e316196269df98ed408186a945b803 Mon Sep 17 00:00:00 2001 From: Kari Salminen Date: Wed, 22 Oct 2008 20:29:17 +0000 Subject: Shut up MSVC and add FIXMEs to Sword's listSaves and ThemeEngine's loadThemeXML. svn-id: r34839 --- gui/ThemeEngine.cpp | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) (limited to 'gui') diff --git a/gui/ThemeEngine.cpp b/gui/ThemeEngine.cpp index 13fd1ea24d..2df6b5ec47 100644 --- a/gui/ThemeEngine.cpp +++ b/gui/ThemeEngine.cpp @@ -525,7 +525,8 @@ bool ThemeEngine::loadThemeXML(const Common::String &themeName) { if (!node.exists() || !node.isReadable()) return false; - Common::Archive *archive; + // FIXME: Should this be initialized to something else than NULL? + Common::Archive *archive = NULL; if (node.getName().hasSuffix(".zip") && !node.isDirectory()) { #ifdef USE_ZLIB @@ -544,6 +545,8 @@ bool ThemeEngine::loadThemeXML(const Common::String &themeName) { } Common::File themercFile; + // FIXME: Possibly dereferencing a NULL pointer here if the node's + // name doesn't have a ".zip" suffix and the node is not a directory. themercFile.open("THEMERC", *archive); if (!themercFile.isOpen()) { delete archive; -- cgit v1.2.3