From dfce3faabd81d434f06e6654eaca9cf992379935 Mon Sep 17 00:00:00 2001 From: Willem Jan Palenstijn Date: Sat, 27 May 2006 14:41:15 +0000 Subject: add fixme about scrolling in about dialog svn-id: r22685 --- gui/about.cpp | 5 +++++ 1 file changed, 5 insertions(+) (limited to 'gui') diff --git a/gui/about.cpp b/gui/about.cpp index 90f7eb3600..1dc55b985d 100644 --- a/gui/about.cpp +++ b/gui/about.cpp @@ -191,6 +191,11 @@ void AboutDialog::drawDialog() { // in the right way. Should be even faster... const int firstLine = _scrollPos / _lineHeight; const int lastLine = MIN((_scrollPos + _h) / _lineHeight + 1, (uint32)_lines.size()); + // FIXME: There's some confusion here about the meaning of 'yOff'. + // The setDrawArea call above makes it possible to render text + // vertically from _y to _y+_h, while the line below assumes text + // is drawn from _y+yOff down. This causes leftover pixels + // the top while scrolling. int y = _y + yOff - (_scrollPos % _lineHeight); for (int line = firstLine; line < lastLine; line++) { -- cgit v1.2.3