summaryrefslogtreecommitdiff
path: root/src/heretic
diff options
context:
space:
mode:
authorSimon Howard2014-11-27 16:54:05 -0500
committerSimon Howard2014-11-27 16:54:05 -0500
commit06821e944818e7f064aeb95cbdef5f12dd85a729 (patch)
tree0a5429c18b7673f5e78def94767b020c389bcb78 /src/heretic
parent5eeef20d70fc978372058371d29821dc27b019a5 (diff)
downloadchocolate-doom-06821e944818e7f064aeb95cbdef5f12dd85a729.tar.gz
chocolate-doom-06821e944818e7f064aeb95cbdef5f12dd85a729.tar.bz2
chocolate-doom-06821e944818e7f064aeb95cbdef5f12dd85a729.zip
hexen: audit calls to P_StartACS().
Scripts can have a maximum of three arguments when started (see ACS_Execute / #80 linedef special type). This means that the array of arguments passed must be at least three elements in length. When loading scripts, check the argument count never exceeds 3, and print a warning message if it does. Don't pass pointers to structure members implicitly treating them as elements of an array (as this relies on compiler-dependent behavior as to how structure members are laid out). Instead, copy values into a temporary array to make the intended behavior explicit. This fixes #477. Thanks to Quasar for reporting it.
Diffstat (limited to 'src/heretic')
0 files changed, 0 insertions, 0 deletions