summaryrefslogtreecommitdiff
path: root/HACKING
AgeCommit message (Collapse)Author
2015-02-26Tweak HACKING style guide.Simon Howard
There was no example for how to write function calls. Do this to make clear that there should be no space between the function name and the open paren. Give examples of assignments and if() conditions as well, and tweak the for() style - there's no reason to omit spaces around operators for the looping conditions.
2014-10-24Replace strdup() with M_StringDuplicate().Simon Howard
strdup() can theoretically fail and return NULL. This could lead to a crash or undesirable behavior. Add M_StringDuplicate() which does the same thing but exits with an error if a string cannot be allocated. This fixes #456. Thanks to Quasar for the suggestion.
2014-05-05Clean up file headers.Simon Howard
This change rewrites and simplifies the copyright headers at the top of all source files: * Remove "Emacs style mode select" line; this line was included in the headers for the originally released source files and appears to be to set the file type for old versions of Emacs. I'm not sure entirely why it was required but I don't think it is any more. * Remove "You should have received a copy of..." text from copyright header. This refers to the old 59 Temple Place address where the FSF headquarters used to be located and is no longer correct. Rather than change to the new address, just remove the paragraph as it is superfluous anyway. This fixes #311. * Remove ---- separator lines so that the file headers are barer and more simplified.
2014-04-01Replace all snprintf() calls with M_snprintf().Simon Howard
The Windows API has an _snprintf function that is not the same as Unix's snprintf(): if the string is truncated then no trailing NUL character is appended. This makes the function unsafe. Define a replacement/wrapper called M_snprintf that works the same but always appends a trailing NUL, for safety on Windows and other OSes that behave like this. Do the same thing for vsnprintf(), and update HACKING to list snprintf/vsnprintf as forbidden functions. This fixes #375; thanks to Quasar for pointing out the different behavior of these functions.
2014-03-29HACKING: Add note about unsafe C functions.Simon Howard
Add a section to the HACKING file listing unsafe C library functions that should not be used.
2011-03-28Add vim modeline for text wrapping to documentation text files.Simon Howard
Subversion-branch: /trunk/chocolate-doom Subversion-revision: 2315
2007-06-21Add portability section to HACKING file.Simon Howard
Subversion-branch: /trunk/chocolate-doom Subversion-revision: 921
2006-10-16Reformat coding style file. Add stuff about hungarian notation, jwz tabSimon Howard
characters link and an introduction giving a brief explanation for the choices. Subversion-branch: /trunk/chocolate-doom Subversion-revision: 703
2006-09-20Remove tab characters :-)Simon Howard
Subversion-branch: /trunk/chocolate-doom Subversion-revision: 632
2006-09-20Add HACKING file with guidelines for Chocolate Doom hackers.Simon Howard
Subversion-branch: /trunk/chocolate-doom Subversion-revision: 631