diff options
author | Max Horn | 2004-01-06 12:02:18 +0000 |
---|---|---|
committer | Max Horn | 2004-01-06 12:02:18 +0000 |
commit | 0133e40d1118eb58e89613f3e3e0d2e97a891fb3 (patch) | |
tree | 0a0e71c7d970e4f278730ca419f5f6a30e488b3a | |
parent | 01c29eabf3a56e70a1262281f8435e1c5887163e (diff) | |
download | scummvm-rg350-0133e40d1118eb58e89613f3e3e0d2e97a891fb3.tar.gz scummvm-rg350-0133e40d1118eb58e89613f3e3e0d2e97a891fb3.tar.bz2 scummvm-rg350-0133e40d1118eb58e89613f3e3e0d2e97a891fb3.zip |
This one (_blitAlso) is very odd, I can't quite figure out where it is needed. Please report any regressions to me
svn-id: r12171
-rw-r--r-- | scumm/string.cpp | 19 |
1 files changed, 17 insertions, 2 deletions
diff --git a/scumm/string.cpp b/scumm/string.cpp index 64a696d5dc..7f21ead22d 100644 --- a/scumm/string.cpp +++ b/scumm/string.cpp @@ -446,8 +446,23 @@ void ScummEngine::drawString(int a) { } } else { if (a == 1 && _version >= 6) { - if (_string[a].no_talk_anim == 0) - _charset->_blitAlso = true; + // FIXME: Fingolfin would like to know what this code is good + // for, exactly. It seems it was added a *looong* time ago, in + // the old CVS module. See revisions 1.5 and 1.37 of the + // original string.cpp file. + // In particular, what kind of regressions might occur when it + // is removed, I wonder... so I am disabling it for now. + // Please report any regressions you observe to Fingolfin :-) + // + // Note #1: _blitAlso causes things to be "imprinted" on the + // room background. Maybe it is used in some room to write + // some text 'permanently' ? + // Note #2: If triggered "accidentaly", this code could also + // cause code to be left printed when it shouldn't... + if (_string[a].no_talk_anim == false) { +warning("Would have set _charset->_blitAlso = true (wanted to print '%c' = %d\n", c, c); +// _charset->_blitAlso = true; + } } if (c >= 0x80 && _CJKMode) c += buf[i++] * 256; |