aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMax Horn2002-11-29 14:22:31 +0000
committerMax Horn2002-11-29 14:22:31 +0000
commit11db3df38bc4b28d72bbd248baae9e9dc59ca332 (patch)
treec3b015e4e0d6283bcf0ed69f00f2bffc6b87be44
parent6823934a6598dc9b7bfba6647389c2f72353cc9f (diff)
downloadscummvm-rg350-11db3df38bc4b28d72bbd248baae9e9dc59ca332.tar.gz
scummvm-rg350-11db3df38bc4b28d72bbd248baae9e9dc59ca332.tar.bz2
scummvm-rg350-11db3df38bc4b28d72bbd248baae9e9dc59ca332.zip
added MonkeyVGA palette fix, and a FIXME comment
svn-id: r5745
-rw-r--r--scumm/gfx.cpp7
1 files changed, 6 insertions, 1 deletions
diff --git a/scumm/gfx.cpp b/scumm/gfx.cpp
index 08f8f7e79c..71dbe9e03b 100644
--- a/scumm/gfx.cpp
+++ b/scumm/gfx.cpp
@@ -447,7 +447,12 @@ void Scumm::setPaletteFromPtr(byte *ptr)
b = *ptr++;
// This comparison might look wierd, but it's what the disassembly (DOTT) says!
- if ((_features & GF_AFTER_V7) || (i <= 15 || r < 252 || g < 252 || b < 252)) {
+ // FIXME: Fingolfin still thinks it looks weird: the value 252 = 4*63 clearly comes from
+ // the days 6/6/6 palettes were used, OK. But it breaks MonkeyVGA, so I had to add a
+ // check for that. And somebody before me added a check for V7 games, turning this
+ // off there, too... I wonder if it hurts other games, too? What exactly is broken
+ // if we remove this patch?
+ if ((_features & GID_MONKEY_VGA) || (_features & GF_AFTER_V7) || (i <= 15 || r < 252 || g < 252 || b < 252)) {
*dest++ = r;
*dest++ = g;
*dest++ = b;