diff options
| author | Littleboy | 2012-08-21 23:16:52 -0400 | 
|---|---|---|
| committer | Littleboy | 2012-08-27 21:49:40 -0400 | 
| commit | 275aded0b0e485eead8d5bdac48d9c8dc1a6ef9c (patch) | |
| tree | f2730b34374edec109ada9671295da5563781f0d | |
| parent | bc4e10dabca5b76283eb6fb431702ccd92a001c0 (diff) | |
| download | scummvm-rg350-275aded0b0e485eead8d5bdac48d9c8dc1a6ef9c.tar.gz scummvm-rg350-275aded0b0e485eead8d5bdac48d9c8dc1a6ef9c.tar.bz2 scummvm-rg350-275aded0b0e485eead8d5bdac48d9c8dc1a6ef9c.zip  | |
LASTEXPRESS: Remove unnecessary casts
| -rw-r--r-- | engines/lastexpress/data/subtitle.cpp | 6 | ||||
| -rw-r--r-- | engines/lastexpress/entities/entity.cpp | 4 | ||||
| -rw-r--r-- | engines/lastexpress/entities/entity.h | 6 | ||||
| -rw-r--r-- | engines/lastexpress/game/action.cpp | 2 | ||||
| -rw-r--r-- | engines/lastexpress/game/entities.cpp | 2 | ||||
| -rw-r--r-- | engines/lastexpress/game/inventory.cpp | 4 | ||||
| -rw-r--r-- | engines/lastexpress/game/savepoint.cpp | 4 | 
7 files changed, 14 insertions, 14 deletions
diff --git a/engines/lastexpress/data/subtitle.cpp b/engines/lastexpress/data/subtitle.cpp index a9a8284588..4d19c02aa7 100644 --- a/engines/lastexpress/data/subtitle.cpp +++ b/engines/lastexpress/data/subtitle.cpp @@ -210,10 +210,10 @@ void SubtitleManager::setTime(uint16 time) {  	_currentIndex = -1;  	// Find the appropriate line to show -	for (int16 i = 0; i < (int16)_subtitles.size(); i++) { +	for (uint i = 0; i < _subtitles.size(); i++) {  		if ((time >= _subtitles[i]->getTimeStart()) && (time <= _subtitles[i]->getTimeStop())) {  			// Keep the index of the line to show -			_currentIndex = i; +			_currentIndex = (int16)i;  			return;  		}  	} @@ -237,7 +237,7 @@ Common::Rect SubtitleManager::draw(Graphics::Surface *surface) {  	// Draw the current line  	assert(_currentIndex >= 0 && _currentIndex < (int16)_subtitles.size()); -	return _subtitles[_currentIndex]->draw(surface, _font); +	return _subtitles[(uint16)_currentIndex]->draw(surface, _font);  }  } // End of namespace LastExpress diff --git a/engines/lastexpress/entities/entity.cpp b/engines/lastexpress/entities/entity.cpp index 88b2ada185..dad5e67392 100644 --- a/engines/lastexpress/entities/entity.cpp +++ b/engines/lastexpress/entities/entity.cpp @@ -50,7 +50,7 @@ EntityData::EntityCallData::~EntityCallData() {  	SAFE_DELETE(sequence3);  } -void EntityData::EntityCallData::syncString(Common::Serializer &s, Common::String &string, int length) const { +void EntityData::EntityCallData::syncString(Common::Serializer &s, Common::String &string, uint length) const {  	char seqName[13];  	memset(&seqName, 0, length); @@ -117,7 +117,7 @@ EntityData::EntityParameters *EntityData::getParameters(uint callback, byte inde  	return _parameters[callback].parameters[index];  } -int EntityData::getCallback(uint callback) const { +byte EntityData::getCallback(uint callback) const {  	if (callback >= 16)  		error("[EntityData::getCallback] Invalid callback value (was: %d, max: 16)", callback); diff --git a/engines/lastexpress/entities/entity.h b/engines/lastexpress/entities/entity.h index c45367c43c..c67d13db9e 100644 --- a/engines/lastexpress/entities/entity.h +++ b/engines/lastexpress/entities/entity.h @@ -822,7 +822,7 @@ public:  		 * @param	string	The string.  		 * @param	length	Length of the string.  		 */ -		void syncString(Common::Serializer &s, Common::String &string, int length) const; +		void syncString(Common::Serializer &s, Common::String &string, uint length) const;  		// Serializable  		void saveLoadWithSerializer(Common::Serializer &s); @@ -845,8 +845,8 @@ public:  	EntityParameters     *getCurrentParameters(byte index = 0) { return getParameters(_data.currentCall, index); }  	EntityCallParameters *getCurrentCallParameters() { return &_parameters[_data.currentCall]; } -	int                   getCallback(uint callback) const; -	int                   getCurrentCallback() { return getCallback(_data.currentCall); } +	byte                  getCallback(uint callback) const; +	byte                  getCurrentCallback() { return getCallback(_data.currentCall); }  	void                  setCallback(uint callback, byte index);  	void                  setCurrentCallback(uint index) { setCallback(_data.currentCall, index); } diff --git a/engines/lastexpress/game/action.cpp b/engines/lastexpress/game/action.cpp index 033fdfc2e8..796abf2ce7 100644 --- a/engines/lastexpress/game/action.cpp +++ b/engines/lastexpress/game/action.cpp @@ -394,7 +394,7 @@ Action::Action(LastExpressEngine *engine) : _engine(engine) {  }  Action::~Action() { -	for (int i = 0; i < (int)_actions.size(); i++) +	for (uint i = 0; i < _actions.size(); i++)  		SAFE_DELETE(_actions[i]);  	_actions.clear(); diff --git a/engines/lastexpress/game/entities.cpp b/engines/lastexpress/game/entities.cpp index de30792405..fafbd7cb64 100644 --- a/engines/lastexpress/game/entities.cpp +++ b/engines/lastexpress/game/entities.cpp @@ -181,7 +181,7 @@ Entities::Entities(LastExpressEngine *engine) : _engine(engine) {  Entities::~Entities() {  	SAFE_DELETE(_header); -	for (int i = 0; i < (int)_entities.size(); i++) +	for (uint i = 0; i < _entities.size(); i++)  		SAFE_DELETE(_entities[i]);  	_entities.clear(); diff --git a/engines/lastexpress/game/inventory.cpp b/engines/lastexpress/game/inventory.cpp index 9e0f583c63..11e7369ee1 100644 --- a/engines/lastexpress/game/inventory.cpp +++ b/engines/lastexpress/game/inventory.cpp @@ -619,7 +619,7 @@ void Inventory::drawEgg() const {  // Blinking egg: we need to blink the egg for delta time, with the blinking getting faster until it's always lit.  void Inventory::drawBlinkingEgg(uint ticks) { -	uint globalTimer = getGlobalTimer(); +	uint globalTimer = (uint)getGlobalTimer();  	uint timerValue = (getProgress().jacket == kJacketGreen) ? 450 : 225;  	if (globalTimer == timerValue || globalTimer == 900) { @@ -653,7 +653,7 @@ void Inventory::drawBlinkingEgg(uint ticks) {  }  void Inventory::blinkEgg() { -	drawItem((CursorStyle)(getMenu()->getGameId() + 39), 608, 448, (_blinkingBrightness == 0) ? -1 : _blinkingBrightness); +	drawItem((CursorStyle)(getMenu()->getGameId() + 39), 608, 448, (_blinkingBrightness == 0) ? -1 : (int16)_blinkingBrightness);  	askForRedraw(); diff --git a/engines/lastexpress/game/savepoint.cpp b/engines/lastexpress/game/savepoint.cpp index 6b2dfc5930..8d14ec386b 100644 --- a/engines/lastexpress/game/savepoint.cpp +++ b/engines/lastexpress/game/savepoint.cpp @@ -202,7 +202,7 @@ void SavePoints::callAndProcess() {  // Misc  //////////////////////////////////////////////////////////////////////////  bool SavePoints::updateEntityFromData(const SavePoint &savepoint) { -	for (int i = 0; i < (int)_data.size(); i++) { +	for (uint i = 0; i < _data.size(); i++) {  		// Not a data savepoint!  		if (!_data[i].entity1) @@ -210,7 +210,7 @@ bool SavePoints::updateEntityFromData(const SavePoint &savepoint) {  		// Found our data!  		if (_data[i].entity1 == savepoint.entity1 && _data[i].action == savepoint.action) { -			debugC(8, kLastExpressDebugLogic, "Update entity from data: entity1=%s, action=%s, param=%d", ENTITY_NAME(_data[i].entity1), ACTION_NAME(_data[i].action), _data[i].param); +			debugC(8, kLastExpressDebugLogic, "Update entity from data: entity1=%s, action=%s, param=%u", ENTITY_NAME(_data[i].entity1), ACTION_NAME(_data[i].action), _data[i].param);  			// the SavePoint param value is the index of the entity call parameter to update  			getEntities()->get(_data[i].entity1)->getParamData()->updateParameters(_data[i].param);  | 
