diff options
| author | Filippos Karapetis | 2015-12-23 23:07:40 +0200 |
|---|---|---|
| committer | Filippos Karapetis | 2015-12-23 23:07:40 +0200 |
| commit | 35f53bb522ded62d0de3198da9eace5299869b73 (patch) | |
| tree | 3b8f0cf9b4d6d17ce42c8395ce154769b1ac0f67 | |
| parent | 9d7a2f4e7f044bbde1c25d0853211820553130c3 (diff) | |
| download | scummvm-rg350-35f53bb522ded62d0de3198da9eace5299869b73.tar.gz scummvm-rg350-35f53bb522ded62d0de3198da9eace5299869b73.tar.bz2 scummvm-rg350-35f53bb522ded62d0de3198da9eace5299869b73.zip | |
LAB: Error out on unused opcodes
This also fixes a warning
| -rw-r--r-- | engines/lab/processroom.cpp | 10 | ||||
| -rw-r--r-- | engines/lab/processroom.h | 6 |
2 files changed, 10 insertions, 6 deletions
diff --git a/engines/lab/processroom.cpp b/engines/lab/processroom.cpp index 7f0c472684..312f153234 100644 --- a/engines/lab/processroom.cpp +++ b/engines/lab/processroom.cpp @@ -267,6 +267,12 @@ void LabEngine::doActions(Action *actionList, CloseDataPtr *closePtrList) { _graphics->loadPict(actionList->_messages[0]); break; + + case kActionLoadBitmap: + error("Unused opcode kActionLoadBitmap has been called"); + + case kActionShowBitmap: + error("Unused opcode kActionShowBitmap has been called"); case kActionTransition: _graphics->doTransition((TransitionType)actionList->_param1, closePtrList, actionList->_messages[0].c_str()); @@ -426,9 +432,7 @@ void LabEngine::doActions(Action *actionList, CloseDataPtr *closePtrList) { break; case kActionLostGame: - // This seems to be unused? - error("Unused opcode LOSTGAME has been called"); - break; + error("Unused opcode kActionLostGame has been called"); case kActionResetBuffer: _graphics->freePict(); diff --git a/engines/lab/processroom.h b/engines/lab/processroom.h index 66111b3a04..31a8f281db 100644 --- a/engines/lab/processroom.h +++ b/engines/lab/processroom.h @@ -39,8 +39,8 @@ enum ActionType { kActionShowDiff = 3, kActionShowDiffLooping = 4, kActionLoadDiff = 5, - kActionLoadBitmap = 6, // unused? - kActionShowBitmap = 7, // unused? + kActionLoadBitmap = 6, // unused + kActionShowBitmap = 7, // unused kActionTransition = 8, kActionNoUpdate = 9, kActionForceUpdate = 10, @@ -65,7 +65,7 @@ enum ActionType { kActionClearSound = 29, kActionWinMusic = 30, kActionWinGame = 31, - kActionLostGame = 32, + kActionLostGame = 32, // unused kActionResetBuffer = 33, kActionSpecialCmd = 34, kActionCShowMessage = 35, |