aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMax Horn2009-07-01 20:51:47 +0000
committerMax Horn2009-07-01 20:51:47 +0000
commit385421e95b59cf904e7e84edfe31d272a66da6b4 (patch)
tree422973c83ffc29f536f073e545d77ef6574fd98b
parentc4f629533082b065d8399a38822cd9cce08ccce8 (diff)
downloadscummvm-rg350-385421e95b59cf904e7e84edfe31d272a66da6b4.tar.gz
scummvm-rg350-385421e95b59cf904e7e84edfe31d272a66da6b4.tar.bz2
scummvm-rg350-385421e95b59cf904e7e84edfe31d272a66da6b4.zip
Flag what looks like a bug in the CMS player code -- somebody should verify and fix this properly
svn-id: r42011
-rw-r--r--engines/scumm/player_v2cms.cpp4
1 files changed, 4 insertions, 0 deletions
diff --git a/engines/scumm/player_v2cms.cpp b/engines/scumm/player_v2cms.cpp
index 97efb4dc63..d628293d7d 100644
--- a/engines/scumm/player_v2cms.cpp
+++ b/engines/scumm/player_v2cms.cpp
@@ -1428,6 +1428,10 @@ int Player_V2CMS::readBuffer(int16 *buffer, const int numSamples) {
}
_tempoSum += _tempo;
+ // FIXME: _tempoSum is declared as char; on some systems char is unsigned.
+ // E.g. on OS X. Hence the following check is always false.
+ // Moral of the story: Use uint8, int8 or any of the other types provided by
+ // ScummVM if you want to ensure signedness and number of available bits.
if (_tempoSum < 0) {
// this have to be called in the same rate as in the original (I think)
processMidiData(1);