aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMax Horn2006-06-24 10:45:47 +0000
committerMax Horn2006-06-24 10:45:47 +0000
commit3b1b06b09c03f87252da45e27098ce60929e9182 (patch)
treeb9677ae62a4149189bf39b8da06d4481a677ea2d
parent5faf5f44c33a0862721d919a72bd7cf5934b8dd7 (diff)
downloadscummvm-rg350-3b1b06b09c03f87252da45e27098ce60929e9182.tar.gz
scummvm-rg350-3b1b06b09c03f87252da45e27098ce60929e9182.tar.bz2
scummvm-rg350-3b1b06b09c03f87252da45e27098ce60929e9182.zip
Added some FIXME comments to AGI engine
svn-id: r23285
-rw-r--r--engines/agi/agi.cpp4
-rw-r--r--engines/agi/savegame.cpp6
2 files changed, 8 insertions, 2 deletions
diff --git a/engines/agi/agi.cpp b/engines/agi/agi.cpp
index 0ef72be6f8..7a34b20e67 100644
--- a/engines/agi/agi.cpp
+++ b/engines/agi/agi.cpp
@@ -434,7 +434,7 @@ int agi_unload_resource(int r, int n) {
return loader->unload_resource(r, n);
}
-const char *_savePath;
+const char *_savePath; // FIXME: Get rid of this
extern AGIMusic *g_agi_music;
struct GameSettings {
@@ -462,7 +462,7 @@ AgiEngine::AgiEngine(OSystem * syst) : Engine(syst) {
_mixer->setVolumeForSoundType(Audio::Mixer::kSFXSoundType, ConfMan.getInt("sfx_volume"));
_mixer->setVolumeForSoundType(Audio::Mixer::kMusicSoundType, ConfMan.getInt("music_volume"));
- _savePath = _saveFileMan->getSavePath();
+ _savePath = _saveFileMan->getSavePath(); // FIXME: Get rid of this
const GameSettings *g;
diff --git a/engines/agi/savegame.cpp b/engines/agi/savegame.cpp
index f996443a81..c9c0de584b 100644
--- a/engines/agi/savegame.cpp
+++ b/engines/agi/savegame.cpp
@@ -126,6 +126,9 @@ void replay_image_stack_call(uint8 type, int16 p1, int16 p2, int16 p3,
static const char *strSig = "AGI:";
+// FIXME: The following wrapper methods are not needed, since class File
+// (resp. class Stream) already offers similar methods.
+
static void write_uint8(Common::File *f, int8 val) {
f->write(&val, 1);
}
@@ -192,6 +195,7 @@ int save_game(char *s, const char *d) {
struct image_stack_element *ptr = image_stack;
Common::File f;
+ // FIXME: Do *not* use Common::File to access savegames, it is not portable!
f.open(s, Common::File::kFileWriteMode);
if (!f.isOpen())
@@ -354,6 +358,7 @@ int load_game(char *s) {
char description[256];
Common::File f;
+ // FIXME: Do *not* use Common::File to access savegames, it is not portable!
f.open(s);
if (!f.isOpen())
@@ -587,6 +592,7 @@ static int select_slot() {
char name[MAX_PATH];
Common::File f;
char sig[8];
+ // FIXME: Do *not* use Common::File to access savegames, it is not portable!
sprintf(name, "%s/%05X_%s_%02d.sav", _savePath, game.crc, game.id, i);
f.open(name);
if (!f.isOpen()) {