aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJohannes Schickel2011-04-22 21:46:38 +0200
committerJohannes Schickel2011-04-22 21:49:25 +0200
commit4a7360d29be53dc8ab4ccd2cd8f508cd21ed1c7c (patch)
treedba0cecf99f94a35cba3f3835bcdecfb51b77004
parente15f9cc0720c25a8afcf3e08ed8db56e7b5fe03c (diff)
downloadscummvm-rg350-4a7360d29be53dc8ab4ccd2cd8f508cd21ed1c7c.tar.gz
scummvm-rg350-4a7360d29be53dc8ab4ccd2cd8f508cd21ed1c7c.tar.bz2
scummvm-rg350-4a7360d29be53dc8ab4ccd2cd8f508cd21ed1c7c.zip
SCUMM: Do not pass non-string literal but "%s" + string to displayMessage.
Since displayMessages usualy vsnprintf internally it is not quite safe to pass any string to it, since it might include a format argument like %n, which is unsafe.
-rw-r--r--engines/scumm/scumm.cpp2
1 files changed, 1 insertions, 1 deletions
diff --git a/engines/scumm/scumm.cpp b/engines/scumm/scumm.cpp
index 7108aabd21..920887e387 100644
--- a/engines/scumm/scumm.cpp
+++ b/engines/scumm/scumm.cpp
@@ -2494,7 +2494,7 @@ void ScummEngine_v90he::runBootscript() {
void ScummEngine::startManiac() {
debug(0, "stub startManiac()");
- displayMessage(0, _("Usually, Maniac Mansion would start now. But ScummVM doesn't do that yet. To play it, go to 'Add Game' in the ScummVM start menu and select the 'Maniac' directory inside the Tentacle game directory."));
+ displayMessage(0, "%s", _("Usually, Maniac Mansion would start now. But ScummVM doesn't do that yet. To play it, go to 'Add Game' in the ScummVM start menu and select the 'Maniac' directory inside the Tentacle game directory."));
}
#pragma mark -