aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMatthew Hoops2011-08-04 11:02:11 -0400
committerMatthew Hoops2011-08-04 11:02:11 -0400
commit51fc76acd4707b9ce3172fbff9cc523a389a52b3 (patch)
treeb2b90a42c0395db9b6f41a3ca9ee7e915c200a80
parent2ea594de8390d9b7829ca6839e267b20e7dfce5e (diff)
downloadscummvm-rg350-51fc76acd4707b9ce3172fbff9cc523a389a52b3.tar.gz
scummvm-rg350-51fc76acd4707b9ce3172fbff9cc523a389a52b3.tar.bz2
scummvm-rg350-51fc76acd4707b9ce3172fbff9cc523a389a52b3.zip
SCUMM: Add notes on the unused soccer u32 opcodes
Might be nice to implement the soccer editor one day in the future, but it's definitely a secondary goal. In fact, I'm not even sure how to access it yet other than jumping to the room (4).
-rw-r--r--engines/scumm/he/logic_he.cpp12
1 files changed, 8 insertions, 4 deletions
diff --git a/engines/scumm/he/logic_he.cpp b/engines/scumm/he/logic_he.cpp
index 562b64aec8..97df4a6250 100644
--- a/engines/scumm/he/logic_he.cpp
+++ b/engines/scumm/he/logic_he.cpp
@@ -915,9 +915,9 @@ int32 LogicHEsoccer::dispatch(int op, int numArgs, int32 *args) {
res = getFromArray(args[0], args[1], args[2]);
break;
+ case 1010: case 1015: case 1018:
+ // Used only by the in-game editor (so, fall through)
default:
- // original range is 1001 - 1021
- warning("unhandled op %d", op);
LogicHE::dispatch(op, numArgs, args);
}
@@ -956,6 +956,7 @@ int LogicHEsoccer::op_1002(int32 *args) {
}
int LogicHEsoccer::op_1003(int32 *args) {
+ // NOTE: This function is never called, so it's here for reference only
double data[6], out[3];
int i;
@@ -2237,7 +2238,7 @@ int LogicHEsoccer::op_1017(int32 *args) {
int LogicHEsoccer::op_1019(int32 *args) {
// Used at the beginning of a match
- // Initializes some arrays. Player positions?
+ // Initializes some arrays. Field parameters?
// These two arrays are used in op_1014 and op_1015
for (int i = 0; i < 4096; i++)
@@ -2246,6 +2247,9 @@ int LogicHEsoccer::op_1019(int32 *args) {
for (int i = 0; i < 585; i++)
_byteArray2[i] = getFromArray(args[0], 0, i);
+ // The remaining code of this function is used for the
+ // built-in editor.
+
// Deallocate the two integer arrays
if (_intArraysAllocated)
op_1020();
@@ -2271,7 +2275,7 @@ int LogicHEsoccer::op_1019(int32 *args) {
}
int LogicHEsoccer::op_1020() {
- // Deallocate integer arrays
+ // Deallocate in-game editor integer arrays
// The arrays can be allocated in op_1015 or op_1019
delete[] _intArray1; _intArray1 = 0;