aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMartin Kiewitz2017-10-07 11:25:12 +0200
committerMartin Kiewitz2017-10-07 11:25:12 +0200
commit54cac32003c83dda0cc647a2ebf2b5340ac5ccd3 (patch)
tree2e00d1f74ed51502bd9398cc1a3ea02548b27bb1
parentae8e4fa8e95f3ae347dfc681330bccc0b09d1f01 (diff)
downloadscummvm-rg350-54cac32003c83dda0cc647a2ebf2b5340ac5ccd3.tar.gz
scummvm-rg350-54cac32003c83dda0cc647a2ebf2b5340ac5ccd3.tar.bz2
scummvm-rg350-54cac32003c83dda0cc647a2ebf2b5340ac5ccd3.zip
Revert "SCI: Add workaround for uninitialized reads in Island of Dr Brain"
This reverts commit ae8e4fa8e95f3ae347dfc681330bccc0b09d1f01. This change is wrong in any case. It should be specific to temp 14+15 at the very least. I also did not get an answer on what is actually happening internally. That's not how we should add workarounds. My review was also still pending.
-rw-r--r--engines/sci/engine/workarounds.cpp1
1 files changed, 0 insertions, 1 deletions
diff --git a/engines/sci/engine/workarounds.cpp b/engines/sci/engine/workarounds.cpp
index 9eb0d7ae8d..842240db47 100644
--- a/engines/sci/engine/workarounds.cpp
+++ b/engines/sci/engine/workarounds.cpp
@@ -325,7 +325,6 @@ const SciWorkaroundEntry uninitializedReadWorkarounds[] = {
{ GID_HOYLE5, 300, 300, 0, "", "export 2", sig_uninitread_hoyle5_1, 0, { WORKAROUND_FAKE, 0 } }, // after passing around cards in hearts
{ GID_ISLANDBRAIN, 100, 937, 0, "IconBar", "dispatchEvent", NULL, 58, { WORKAROUND_FAKE, 0 } }, // when using ENTER at the startup menu - bug #5241
{ GID_ISLANDBRAIN, 140, 140, 0, "piece", "init", NULL, 3, { WORKAROUND_FAKE, 1 } }, // first puzzle right at the start, some initialization variable. bnt is done on it, and it should be non-0
- { GID_ISLANDBRAIN, 180, 190, 0, "word", "dispatchEvent", NULL, -1, { WORKAROUND_FAKE, 0 } }, // holding down enter key during the word search puzzle, temps 14 and 15
{ GID_ISLANDBRAIN, 200, 268, 0, "anElement", "select", NULL, 0, { WORKAROUND_FAKE, 0 } }, // elements puzzle, gets used before super TextIcon
{ GID_JONES, 1, 232, 0, "weekendText", "draw", sig_uninitread_jones_1, 0, { WORKAROUND_FAKE, 0 } }, // jones/cd only - gets called during the game
{ GID_JONES, 1, 255, 0, "", "export 0", NULL, -1, { WORKAROUND_FAKE, 0 } }, // jones/cd only - called when a game ends, temps 13 and 14