aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMax Horn2003-03-07 02:42:39 +0000
committerMax Horn2003-03-07 02:42:39 +0000
commit5537fc3df3b78f68e0b5923f9d4628350f9771c2 (patch)
tree1c1cf246f39ca26623f469738b6274a959c8b65d
parent22e6d4581b86b5d134f8557c78cbdba32f9409e0 (diff)
downloadscummvm-rg350-5537fc3df3b78f68e0b5923f9d4628350f9771c2.tar.gz
scummvm-rg350-5537fc3df3b78f68e0b5923f9d4628350f9771c2.tar.bz2
scummvm-rg350-5537fc3df3b78f68e0b5923f9d4628350f9771c2.zip
ouch - fixed OOB access on _baseFLObject; also added various sanity checks (thx valgrind)
svn-id: r6732
-rw-r--r--scumm/script.cpp7
1 files changed, 6 insertions, 1 deletions
diff --git a/scumm/script.cpp b/scumm/script.cpp
index 9a3a020d0f..6730ba1171 100644
--- a/scumm/script.cpp
+++ b/scumm/script.cpp
@@ -234,6 +234,7 @@ void Scumm::getScriptBaseAddress() {
case WIO_INVENTORY: /* inventory script * */
idx = getObjectIndex(ss->number);
_scriptOrgPointer = getResourceAddress(rtInventory, idx);
+ assert(idx < _maxInventoryItems);
_lastCodePtr = &_baseInventoryItems[idx];
break;
@@ -241,22 +242,26 @@ void Scumm::getScriptBaseAddress() {
case WIO_ROOM: /* room script */
if (_features & GF_AFTER_V8) {
_scriptOrgPointer = getResourceAddress(rtRoomScripts, _roomResource);
+ assert(_roomResource < res.num[rtRoomScripts]);
_lastCodePtr = &res.address[rtRoomScripts][_roomResource];
} else {
_scriptOrgPointer = getResourceAddress(rtRoom, _roomResource);
+ assert(_roomResource < _maxRooms);
_lastCodePtr = &_baseRooms[_roomResource];
}
break;
case WIO_GLOBAL: /* global script */
_scriptOrgPointer = getResourceAddress(rtScript, ss->number);
+ assert(ss->number < _maxScripts);
_lastCodePtr = &_baseScripts[ss->number];
break;
case WIO_FLOBJECT: /* flobject script */
idx = getObjectIndex(ss->number);
_scriptOrgPointer = getResourceAddress(rtFlObject, _objs[idx].fl_object_index);
- _lastCodePtr = &_baseFLObject[ss->number];
+ assert(idx < _maxFLObject);
+ _lastCodePtr = &_baseFLObject[idx];
break;
default:
error("Bad type while getting base address");