aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorPaul Gilbert2009-06-01 08:46:39 +0000
committerPaul Gilbert2009-06-01 08:46:39 +0000
commit5bb449b2bf443c30dd9fa312a426c81d40baf9dc (patch)
tree14b34f5daadb35568f3aa56735c6221f68a2bd50
parentc730e0290d98f0c18ea88a5b7b75ff8756f2ccdb (diff)
downloadscummvm-rg350-5bb449b2bf443c30dd9fa312a426c81d40baf9dc.tar.gz
scummvm-rg350-5bb449b2bf443c30dd9fa312a426c81d40baf9dc.tar.bz2
scummvm-rg350-5bb449b2bf443c30dd9fa312a426c81d40baf9dc.zip
Removed the remaining two FIXME's - my analysis of the data indicates no issues with structure packing, and all multi-byte data accesses are wrapped using loadShort/saveShort, which is endian safe
svn-id: r41096
-rw-r--r--engines/cruise/saveload.cpp3
1 files changed, 0 insertions, 3 deletions
diff --git a/engines/cruise/saveload.cpp b/engines/cruise/saveload.cpp
index 4230829bcf..0084b10cb9 100644
--- a/engines/cruise/saveload.cpp
+++ b/engines/cruise/saveload.cpp
@@ -258,7 +258,6 @@ static void syncOverlays2(Common::Serializer &s) {
// save BSS
s.syncAsSint16LE(ovlData->sizeOfData4);
if (ovlData->sizeOfData4)
- // FIXME: Endian and structure packing problems for this data pointer
s.syncBytes(ovlData->data4Ptr, ovlData->sizeOfData4);
// save variables
@@ -344,8 +343,6 @@ void syncScript(Common::Serializer &s, scriptInstanceStruct *entry) {
s.syncAsSint16LE(ptr->varA);
if (ptr->varA) {
- // FIXME: This code is not endian safe, and breaks if struct
- // packing changes. Read/write the members one by one instead.
if (s.isLoading())
ptr->var6 = (byte *)mallocAndZero(ptr->varA);
s.syncBytes(ptr->var6, ptr->varA);