aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorFilippos Karapetis2010-06-17 23:53:30 +0000
committerFilippos Karapetis2010-06-17 23:53:30 +0000
commit6946167f34518d16036e37ce19683be1592a9424 (patch)
tree681a2872b49996529cb6a0b677e56ed0559068fa
parentc9c9a21a0836edfc824e821702e886a656167692 (diff)
downloadscummvm-rg350-6946167f34518d16036e37ce19683be1592a9424.tar.gz
scummvm-rg350-6946167f34518d16036e37ce19683be1592a9424.tar.bz2
scummvm-rg350-6946167f34518d16036e37ce19683be1592a9424.zip
Strict mode: error out on unhandled subops, to note if they actually exist and where they're used
svn-id: r49975
-rw-r--r--engines/sci/engine/kgraphics.cpp20
-rw-r--r--engines/sci/graphics/paint16.cpp2
2 files changed, 11 insertions, 11 deletions
diff --git a/engines/sci/engine/kgraphics.cpp b/engines/sci/engine/kgraphics.cpp
index 8f59f553a7..15567a08e3 100644
--- a/engines/sci/engine/kgraphics.cpp
+++ b/engines/sci/engine/kgraphics.cpp
@@ -173,7 +173,7 @@ static reg_t kSetCursorSci11(EngineState *s, int argc, reg_t *argv) {
g_sci->_gfxCursor->kernelSetView(argv[0].toUint16(), argv[1].toUint16(), argv[2].toUint16(), hotspot);
break;
default :
- warning("kSetCursor: Unhandled case: %d arguments given", argc);
+ error("kSetCursor: Unhandled case: %d arguments given", argc);
break;
}
return s->r_acc;
@@ -186,7 +186,7 @@ reg_t kSetCursor(EngineState *s, int argc, reg_t *argv) {
case SCI_VERSION_1_1:
return kSetCursorSci11(s, argc, argv);
default:
- warning("Unknown SetCursor type");
+ error("Unknown SetCursor type");
return NULL_REG;
}
}
@@ -316,7 +316,7 @@ reg_t kGraph(EngineState *s, int argc, reg_t *argv) {
return g_sci->_gfxPaint16->kernelGraphSaveUpscaledHiresBox(rect);
default:
- warning("Unsupported kGraph() operation %04x", argv[0].toSint16());
+ error("Unsupported kGraph() operation %04x", argv[0].toSint16());
}
return s->r_acc;
@@ -627,7 +627,7 @@ reg_t kPalette(EngineState *s, int argc, reg_t *argv) {
break;
}
default:
- warning("kPalette(%d), not implemented", argv[0].toUint16());
+ error("kPalette(%d), not implemented", argv[0].toUint16());
}
return s->r_acc;
@@ -680,7 +680,7 @@ reg_t kPalVary(EngineState *s, int argc, reg_t *argv) {
break;
}
default:
- warning("kPalVary(%d), not implemented (argc = %d)", operation, argc);
+ error("kPalVary(%d), not implemented (argc = %d)", operation, argc);
}
return NULL_REG;
}
@@ -702,7 +702,7 @@ reg_t kPortrait(EngineState *s, int argc, reg_t *argv) {
Common::String resourceName = s->_segMan->getString(argv[1]);
s->r_acc = g_sci->_gfxPaint16->kernelPortraitLoad(resourceName);
} else {
- warning("kPortrait(loadResource) called with unsupported argc %d", argc);
+ error("kPortrait(loadResource) called with unsupported argc %d", argc);
}
break;
}
@@ -720,7 +720,7 @@ reg_t kPortrait(EngineState *s, int argc, reg_t *argv) {
g_sci->_gfxPaint16->kernelPortraitShow(resourceName, position, resourceNum, noun, verb, cond, seq);
return SIGNAL_REG;
} else {
- warning("kPortrait(show) called with unsupported argc %d", argc);
+ error("kPortrait(show) called with unsupported argc %d", argc);
}
break;
}
@@ -729,12 +729,12 @@ reg_t kPortrait(EngineState *s, int argc, reg_t *argv) {
uint16 portraitId = argv[1].toUint16();
g_sci->_gfxPaint16->kernelPortraitUnload(portraitId);
} else {
- warning("kPortrait(unload) called with unsupported argc %d", argc);
+ error("kPortrait(unload) called with unsupported argc %d", argc);
}
break;
}
default:
- warning("kPortrait(%d), not implemented (argc = %d)", operation, argc);
+ error("kPortrait(%d), not implemented (argc = %d)", operation, argc);
}
return s->r_acc;
@@ -1160,7 +1160,7 @@ reg_t kShowMovie(EngineState *s, int argc, reg_t *argv) {
initGraphics(screenWidth, screenHeight, screenWidth > 320, NULL);
if (g_system->getScreenFormat().bytesPerPixel == 1) {
- warning("This video requires >8bpp color to be displayed, but could not switch to RGB color mode.");
+ error("This video requires >8bpp color to be displayed, but could not switch to RGB color mode.");
return NULL_REG;
}
diff --git a/engines/sci/graphics/paint16.cpp b/engines/sci/graphics/paint16.cpp
index a52fd304e2..feda84e993 100644
--- a/engines/sci/graphics/paint16.cpp
+++ b/engines/sci/graphics/paint16.cpp
@@ -514,7 +514,7 @@ reg_t GfxPaint16::kernelDisplay(const char *text, int argc, reg_t *argv) {
bRedraw = 0;
break;
default:
- warning("Unknown kDisplay argument %X", displayArg);
+ error("Unknown kDisplay argument %X", displayArg);
break;
}
}