aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorWillem Jan Palenstijn2009-10-01 11:06:38 +0000
committerWillem Jan Palenstijn2009-10-01 11:06:38 +0000
commit7d6848dfa3ceebe2d618c8ba59a03cae631bacf1 (patch)
tree8862fd5feadddbadb6cc3b8cc80dcbf4546c3c2c
parent5a8b81119b5292036a6d63c94a37ced70ff9c083 (diff)
downloadscummvm-rg350-7d6848dfa3ceebe2d618c8ba59a03cae631bacf1.tar.gz
scummvm-rg350-7d6848dfa3ceebe2d618c8ba59a03cae631bacf1.tar.bz2
scummvm-rg350-7d6848dfa3ceebe2d618c8ba59a03cae631bacf1.zip
SCI: Add some fixmes noted by salty-horse.
svn-id: r44513
-rw-r--r--engines/sci/console.cpp4
-rw-r--r--engines/sci/sfx/softseq/amiga.cpp1
2 files changed, 4 insertions, 1 deletions
diff --git a/engines/sci/console.cpp b/engines/sci/console.cpp
index ee300d251d..2e00127351 100644
--- a/engines/sci/console.cpp
+++ b/engines/sci/console.cpp
@@ -2719,7 +2719,9 @@ bool Console::cmdAddresses(int argc, const char **argv) {
return true;
}
-int parse_reg_t(EngineState *s, const char *str, reg_t *dest) { // Returns 0 on success
+// Returns 0 on success
+int parse_reg_t(EngineState *s, const char *str, reg_t *dest) {
+ // FIXME: Stop this function from changing str.
int rel_offsetting = 0;
const char *offsetting = NULL;
// Non-NULL: Parse end of string for relative offsets
diff --git a/engines/sci/sfx/softseq/amiga.cpp b/engines/sci/sfx/softseq/amiga.cpp
index 7eebadbf59..ff4057be3a 100644
--- a/engines/sci/sfx/softseq/amiga.cpp
+++ b/engines/sci/sfx/softseq/amiga.cpp
@@ -565,6 +565,7 @@ static void ami_event(sfx_softseq_t *self, byte command, int argc, byte *argv) {
void ami_poll(sfx_softseq_t *self, byte *dest, int len) {
int i, j;
int16 *buf = (int16 *) dest;
+ // FIXME: memleak
int16 *buffers = (int16*)malloc(len * 2 * CHANNELS_NR);
memset(buffers, 0, len * 2 * CHANNELS_NR);