SCI32: Fix broken palette cycling in SCI2/2.1early games

This fixes the incorrect appearance of the Sierra logo in PQ4 when
the main menu appears in hi-res mode.

The behaviour of kPalCycle(SetCycle) changed in between 2.1early
and 2.1mid to fix an off-by-one error that prevented the last
palette entry in a cycle range from being used. Some earlier games,
like PQ4CD in hi-res mode, relied on this behaviour, and would
render incorrectly if the last palette entry in a range was used.

1 files changed, 4 insertions, 1 deletions

diff --git a/engines/sci/graphics/palette32.cpp b/engines/sci/graphics/palette32.cpp
index 6b719f8e86..ec3d912365 100644
--- a/engines/sci/graphics/palette32.cpp
+++ b/engines/sci/graphics/palette32.cpp
@@ -556,7 +556,10 @@ void GfxPalette32::setCycle(const uint8 fromColor, const uint8 toColor, const in
 		clearCycleMap(cycler->fromColor, cycler->numColorsToCycle);
 	}
 
-	const uint16 numColorsToCycle = toColor - fromColor + 1;
+	uint16 numColorsToCycle = toColor - fromColor;
+	if (getSciVersion() >= SCI_VERSION_2_1_MIDDLE || g_sci->getGameId() == GID_KQ7) {
+		numColorsToCycle += 1;
+	}
 	cycler->fromColor = fromColor;
 	cycler->numColorsToCycle = numColorsToCycle;
 	cycler->currentCycle = fromColor;