diff options
| author | Bastien Bouclet | 2017-09-20 19:42:09 +0200 |
|---|---|---|
| committer | Bastien Bouclet | 2017-09-22 07:06:21 +0200 |
| commit | be67f0d8bfb4148e014931cce63b52e84ed95ee6 (patch) | |
| tree | 81b68af6661ffee051c2100548f452954c7d72b2 | |
| parent | 3eb82462e772832a902ba336b680e2a961339ee1 (diff) | |
| download | scummvm-rg350-be67f0d8bfb4148e014931cce63b52e84ed95ee6.tar.gz scummvm-rg350-be67f0d8bfb4148e014931cce63b52e84ed95ee6.tar.bz2 scummvm-rg350-be67f0d8bfb4148e014931cce63b52e84ed95ee6.zip | |
COMMON: Remove DisposeAfterUse default value from dynamic write memory streams
The default value was DisposeAfterUse::NO, which made it very easy to
accidentally leak memory by omitting to specify a value.
| -rw-r--r-- | common/memstream.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/common/memstream.h b/common/memstream.h index 0338d35378..f6bf990208 100644 --- a/common/memstream.h +++ b/common/memstream.h @@ -184,7 +184,7 @@ protected: _size = new_len; } public: - MemoryWriteStreamDynamic(DisposeAfterUse::Flag disposeMemory = DisposeAfterUse::NO) : _capacity(0), _size(0), _ptr(0), _data(0), _pos(0), _disposeMemory(disposeMemory) {} + explicit MemoryWriteStreamDynamic(DisposeAfterUse::Flag disposeMemory) : _capacity(0), _size(0), _ptr(0), _data(0), _pos(0), _disposeMemory(disposeMemory) {} ~MemoryWriteStreamDynamic() { if (_disposeMemory) @@ -247,7 +247,7 @@ private: } } public: - MemoryReadWriteStream(DisposeAfterUse::Flag disposeMemory = DisposeAfterUse::NO) : _capacity(0), _size(0), _data(0), _writePos(0), _readPos(0), _pos(0), _length(0), _disposeMemory(disposeMemory), _eos(false) {} + explicit MemoryReadWriteStream(DisposeAfterUse::Flag disposeMemory) : _capacity(0), _size(0), _data(0), _writePos(0), _readPos(0), _pos(0), _length(0), _disposeMemory(disposeMemory), _eos(false) {} ~MemoryReadWriteStream() { if (_disposeMemory) |