aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorTravis Howell2003-05-31 10:33:25 +0000
committerTravis Howell2003-05-31 10:33:25 +0000
commitf5758f3f49e0ff27300de176e1815c27e41b7a3b (patch)
tree51185c4a0d88945f9cb907d6ff5ff1fc1d9a8eb8
parentc26389164fef4066635762dfc27ba7534f2645a0 (diff)
downloadscummvm-rg350-f5758f3f49e0ff27300de176e1815c27e41b7a3b.tar.gz
scummvm-rg350-f5758f3f49e0ff27300de176e1815c27e41b7a3b.tar.bz2
scummvm-rg350-f5758f3f49e0ff27300de176e1815c27e41b7a3b.zip
A few notes, correction and a few more errors
svn-id: r8164
-rw-r--r--simon/simon.h2
-rw-r--r--simon/vga.cpp20
2 files changed, 16 insertions, 6 deletions
diff --git a/simon/simon.h b/simon/simon.h
index 0d7cfeec37..1323ec63b7 100644
--- a/simon/simon.h
+++ b/simon/simon.h
@@ -656,7 +656,7 @@ public:
void vc_53_no_op();
void vc_54_no_op();
void vc_55_offset_hit_area();
- void vc_56_no_op();
+ void vc_56();
void vc_57_no_op();
void vc_59();
void vc_60_kill_sprite();
diff --git a/simon/vga.cpp b/simon/vga.cpp
index 3d4dee1369..3110d2105a 100644
--- a/simon/vga.cpp
+++ b/simon/vga.cpp
@@ -86,7 +86,7 @@ static const VgaOpcodeProc vga_opcode_table[] = {
&SimonState::vc_53_no_op,
&SimonState::vc_54_no_op,
&SimonState::vc_55_offset_hit_area,
- &SimonState::vc_56_no_op,
+ &SimonState::vc_56,
&SimonState::vc_57_no_op,
&SimonState::vc_58,
&SimonState::vc_59,
@@ -1282,6 +1282,7 @@ void SimonState::vc_27_reset() {
void SimonState::vc_28_dummy_op() {
/* dummy opcode */
_vc_ptr += 8;
+ error("vc_28 - Please report error message and where in game it occured");
}
void SimonState::vc_29_stop_all_sounds() {
@@ -1324,9 +1325,12 @@ void SimonState::vc_34_force_lock() {
}
void SimonState::vc_35() {
+ /* unknown function is simon1dos/simon2dos */
+ /* dummy op in simon1win/simon2win */
/* not used? */
_vc_ptr += 4;
_vga_sprite_changed++;
+ error("vc_35 - Please report error message and where in game it occured");
}
void SimonState::vc_36_saveload_thing() {
@@ -1530,12 +1534,14 @@ void SimonState::vc_52_play_sound() {
}
void SimonState::vc_53_no_op() {
- /* no op */
+ /* dummy op in simon1dos/talkie */
+ /* no op in simon1win */
error("vc_53 - Please report error message and where in game it occured");
}
void SimonState::vc_54_no_op() {
- /* no op */
+ /* dummy op in simon1dos/talkie */
+ /* no op in simon1win */
error("vc_54 - Please report error message and where in game it occured");
}
@@ -1560,7 +1566,7 @@ void SimonState::vc_55_offset_hit_area() {
_need_hitarea_recalc++;
}
-void SimonState::vc_56_no_op() {
+void SimonState::vc_56() {
/* no op in simon1 */
if (_game & GF_SIMON2) {
uint num = vc_read_var_or_word() * _vga_base_delay;
@@ -1591,6 +1597,8 @@ void SimonState::vc_59() {
}
void SimonState::vc_58() {
+ /* no op in simon1dos */
+ /* not used in simon1win? */
if (!(_game & GF_SIMON2))
error("vc_58 - Please report error message and where in game it occured");
uint sprite = _vga_cur_sprite_id;
@@ -1613,7 +1621,9 @@ void SimonState::vc_58() {
}
void SimonState::vc_57_no_op() {
- /* no op */
+ /* unknown function in simon1dos/simon2dos */
+ /* no op in simon1win/simon2win */
+ /* not used? */
error("vc_57 - Please report error message and where in game it occured");
}