aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJamieson Christian2004-04-26 20:34:59 +0000
committerJamieson Christian2004-04-26 20:34:59 +0000
commitf7084c20e95ecb1fa508d0690eaf74e1c566f528 (patch)
tree67c3a8f0279a653486a96f0dfd93a75047236874
parent4ee0365a231eee6baddf32a65ab15a59be6adb00 (diff)
downloadscummvm-rg350-f7084c20e95ecb1fa508d0690eaf74e1c566f528.tar.gz
scummvm-rg350-f7084c20e95ecb1fa508d0690eaf74e1c566f528.tar.bz2
scummvm-rg350-f7084c20e95ecb1fa508d0690eaf74e1c566f528.zip
MIDI control change 18 is no longer transmitted.
It is not a valid MIDI control change message. It is used internally in the SCUMM MIDI tracks to indicate part priority. The only MidiDriver that needs it is Adlib. It should be noted that the priority values are out of bounds for a regular MIDI message anyway. Valid control change values are 0-127, but the priority value ranges from 0-255. This fixes a crash with a certain software MT-32 emulator running under Linux. Thanks to olki for bringing up this issue. svn-id: r13645
-rw-r--r--sound/mididrv.h2
1 files changed, 1 insertions, 1 deletions
diff --git a/sound/mididrv.h b/sound/mididrv.h
index 223c420fcc..24aaab9bf9 100644
--- a/sound/mididrv.h
+++ b/sound/mididrv.h
@@ -154,7 +154,7 @@ public:
virtual void panPosition (byte value) { controlChange (10, value); }
virtual void pitchBendFactor (byte value) = 0;
virtual void detune (byte value) { controlChange (17, value); }
- virtual void priority (byte value) { controlChange (18, value); }
+ virtual void priority (byte value) { }
virtual void sustain (bool value) { controlChange (64, value ? 1 : 0); }
virtual void effectLevel (byte value) { controlChange (91, value); }
virtual void chorusLevel (byte value) { controlChange (93, value); }