aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorLars Skovlund2010-06-17 23:44:01 +0000
committerLars Skovlund2010-06-17 23:44:01 +0000
commitf977faaf9f9d2289adfbc2ccf9338cb24266dce5 (patch)
treefa6b948a644e6bff369d9a960783c4bb4c6a41dd
parent50c3a087e3fb75ac06ea6186909b49885de6226d (diff)
downloadscummvm-rg350-f977faaf9f9d2289adfbc2ccf9338cb24266dce5.tar.gz
scummvm-rg350-f977faaf9f9d2289adfbc2ccf9338cb24266dce5.tar.bz2
scummvm-rg350-f977faaf9f9d2289adfbc2ccf9338cb24266dce5.zip
SCI: Fix a few errors in PlayVMD comment.
svn-id: r49971
-rw-r--r--engines/sci/engine/kgraphics.cpp49
1 files changed, 27 insertions, 22 deletions
diff --git a/engines/sci/engine/kgraphics.cpp b/engines/sci/engine/kgraphics.cpp
index 596f8fb4b7..8f59f553a7 100644
--- a/engines/sci/engine/kgraphics.cpp
+++ b/engines/sci/engine/kgraphics.cpp
@@ -1289,7 +1289,7 @@ reg_t kPlayVMD(EngineState *s, int argc, reg_t *argv) {
break;
case 1:
{
- // Set VMD parameters. Called with a maximum of 5 parameters:
+ // Set VMD parameters. Called with a maximum of 6 parameters:
//
// x, y, flags, gammaBoost, gammaFirst, gammaLast
//
@@ -1305,33 +1305,38 @@ reg_t kPlayVMD(EngineState *s, int argc, reg_t *argv) {
// bit 8 stretch
// gammaBoost boosts palette colors in the range gammaFirst to gammaLast, but
- // only if bit 4 in flags is set. Percent value such that 100% = no amplification
+ // only if bit 4 in flags is set. Percent value such that 0% = no amplification
// These three parameters are optional if bit 4 is clear.
// Also note that the x, y parameters play subtle games if used with subfx 21.
+ // The subtleness has to do with creation of temporary planes and positioning relative to such planes.
int flags = argv[3].offset;
Common::String flagspec;
- if (flags & 1)
- flagspec += "doubled ";
- if (flags & 2)
- flagspec += "dropframes ";
- if (flags & 4)
- flagspec += "blacklines ";
- if (flags & 8)
- flagspec += "bit3 ";
- if (flags & 16)
- flagspec += "gammaboost ";
- if (flags & 32)
- flagspec += "holdblack ";
- if (flags & 64)
- flagspec += "holdlast ";
- if (flags & 128)
- flagspec += "bit7 ";
- if (flags & 256)
- flagspec += "stretch";
-
- warning("VMDFlags: %s", flagspec.c_str());
+ if (argc > 3)
+ {
+ if (flags & 1)
+ flagspec += "doubled ";
+ if (flags & 2)
+ flagspec += "dropframes ";
+ if (flags & 4)
+ flagspec += "blacklines ";
+ if (flags & 8)
+ flagspec += "bit3 ";
+ if (flags & 16)
+ flagspec += "gammaboost ";
+ if (flags & 32)
+ flagspec += "holdblack ";
+ if (flags & 64)
+ flagspec += "holdlast ";
+ if (flags & 128)
+ flagspec += "bit7 ";
+ if (flags & 256)
+ flagspec += "stretch";
+
+ warning("VMDFlags: %s", flagspec.c_str());
+ }
+
warning("x, y: %d, %d", argv[1].offset, argv[2].offset);
if (argc > 4 && flags & 16)