aboutsummaryrefslogtreecommitdiff
path: root/audio
diff options
context:
space:
mode:
authorMartin Kiewitz2015-07-05 21:25:22 +0200
committerMartin Kiewitz2015-07-05 21:25:22 +0200
commit76f21a210169579de6dcb55ac62e7072e6a73aad (patch)
tree1b0cdeccf261c194233a35bc168cf347fe8c8993 /audio
parent396d6f28391956ca6f736f905170a7b2575980b7 (diff)
downloadscummvm-rg350-76f21a210169579de6dcb55ac62e7072e6a73aad.tar.gz
scummvm-rg350-76f21a210169579de6dcb55ac62e7072e6a73aad.tar.bz2
scummvm-rg350-76f21a210169579de6dcb55ac62e7072e6a73aad.zip
AUDIO: Miles Audio AdLib: set default volume 0x7F
set default volume of every midi channel to 0x7F right on startup fixes Amazon Guardians of Eden logo jingle music those values were actually sent to the driver right on startup default value for panning was 0x40, this was adjusted as well
Diffstat (limited to 'audio')
-rw-r--r--audio/miles_adlib.cpp17
1 files changed, 7 insertions, 10 deletions
diff --git a/audio/miles_adlib.cpp b/audio/miles_adlib.cpp
index f033c63b36..903b0a92be 100644
--- a/audio/miles_adlib.cpp
+++ b/audio/miles_adlib.cpp
@@ -350,18 +350,15 @@ void MidiDriver_Miles_AdLib::resetData() {
memset(_physicalFmVoices, 0, sizeof(_physicalFmVoices));
for (byte midiChannel = 0; midiChannel < MILES_MIDI_CHANNEL_COUNT; midiChannel++) {
- _midiChannels[midiChannel].currentPitchBender = MILES_PITCHBENDER_DEFAULT;
- _midiChannels[midiChannel].currentPitchRange = 12;
- // Miles Audio 2: hardcoded pitch range as a global (not channel specific), set to 12
- // Miles Audio 3: pitch range per MIDI channel
+ // defaults, were sent to driver during driver initialization
+ _midiChannels[midiChannel].currentVolume = 0x7F;
+ _midiChannels[midiChannel].currentPanning = 0x40; // center
_midiChannels[midiChannel].currentVolumeExpression = 127;
- // TODO: Miles Audio had currentPanning initialized to 0 inside the driver
- // Simon the sorcerer 2 as well as Return To Zork don't change this control at all
- // inside their XMIDI files, so currentPanning set to 0 will create output output on
- // one speaker only. Maybe there were some default MIDI commands sent to the driver before
- // playing the music. Needs to get investigated further.
- _midiChannels[midiChannel].currentPanning = 63; // center
+ // Miles Audio 2: hardcoded pitch range as a global (not channel specific), set to 12
+ // Miles Audio 3: pitch range per MIDI channel
+ _midiChannels[midiChannel].currentPitchBender = MILES_PITCHBENDER_DEFAULT;
+ _midiChannels[midiChannel].currentPitchRange = 12;
}
}