aboutsummaryrefslogtreecommitdiff
path: root/backends/cloud/dropbox
diff options
context:
space:
mode:
authorAlexander Tkachev2016-07-20 17:30:19 +0600
committerAlexander Tkachev2016-08-24 16:07:55 +0600
commita449ddce15c512e809b9aedad334db6b52628e61 (patch)
treeb40883e0122db298ef294dedf650bcb656befd7f /backends/cloud/dropbox
parentc7fe842f9acf0eeec5453170699ed10394ef0fa5 (diff)
downloadscummvm-rg350-a449ddce15c512e809b9aedad334db6b52628e61.tar.gz
scummvm-rg350-a449ddce15c512e809b9aedad334db6b52628e61.tar.bz2
scummvm-rg350-a449ddce15c512e809b9aedad334db6b52628e61.zip
CLOUD: Fix Cppcheck warnings
Diffstat (limited to 'backends/cloud/dropbox')
-rw-r--r--backends/cloud/dropbox/dropboxstorage.cpp2
-rw-r--r--backends/cloud/dropbox/dropboxuploadrequest.cpp4
2 files changed, 3 insertions, 3 deletions
diff --git a/backends/cloud/dropbox/dropboxstorage.cpp b/backends/cloud/dropbox/dropboxstorage.cpp
index 4171af0443..d7aea012af 100644
--- a/backends/cloud/dropbox/dropboxstorage.cpp
+++ b/backends/cloud/dropbox/dropboxstorage.cpp
@@ -135,7 +135,7 @@ Networking::Request *DropboxStorage::streamFileById(Common::String path, Network
Networking::NetworkReadStreamResponse response = request->execute();
if (callback) (*callback)(response);
- return response.request;
+ return response.request; // no leak here, response.request == request
}
Networking::Request *DropboxStorage::createDirectory(Common::String path, BoolCallback callback, Networking::ErrorCallback errorCallback) {
diff --git a/backends/cloud/dropbox/dropboxuploadrequest.cpp b/backends/cloud/dropbox/dropboxuploadrequest.cpp
index a3d7dd0d6d..ee6f665665 100644
--- a/backends/cloud/dropbox/dropboxuploadrequest.cpp
+++ b/backends/cloud/dropbox/dropboxuploadrequest.cpp
@@ -137,10 +137,10 @@ void DropboxUploadRequest::partUploadedCallback(Networking::JsonResponse respons
//debug("%s", json->stringify(true).c_str());
if (object.contains("error") || object.contains("error_summary")) {
- warning("Dropbox returned error: %s", object.getVal("error_summary")->asString().c_str());
- delete json;
+ warning("Dropbox returned error: %s", object.getVal("error_summary")->asString().c_str());
error.response = json->stringify(true);
finishError(error);
+ delete json;
return;
}