diff options
author | Cameron Cawley | 2019-07-23 17:21:09 +0100 |
---|---|---|
committer | Cameron Cawley | 2019-07-23 17:21:09 +0100 |
commit | 357493082fb9b6b7e66f05394db839da761bbb29 (patch) | |
tree | 12101bd0cdaa3ff03e5b13ebc751a2603ce13684 /backends/platform/android/jni.cpp | |
parent | 1f2882b5a3b07c675a152f2f5e553f40c4bbd5b5 (diff) | |
download | scummvm-rg350-357493082fb9b6b7e66f05394db839da761bbb29.tar.gz scummvm-rg350-357493082fb9b6b7e66f05394db839da761bbb29.tar.bz2 scummvm-rg350-357493082fb9b6b7e66f05394db839da761bbb29.zip |
ANDROID: Fix some Codacy warnings
Diffstat (limited to 'backends/platform/android/jni.cpp')
-rw-r--r-- | backends/platform/android/jni.cpp | 9 |
1 files changed, 3 insertions, 6 deletions
diff --git a/backends/platform/android/jni.cpp b/backends/platform/android/jni.cpp index 47dd5c73cf..ffe60062fb 100644 --- a/backends/platform/android/jni.cpp +++ b/backends/platform/android/jni.cpp @@ -260,9 +260,8 @@ bool JNI::openUrl(const char *url) { } bool JNI::hasTextInClipboard() { - bool hasText = false; JNIEnv *env = JNI::getEnv(); - hasText = env->CallBooleanMethod(_jobj, _MID_hasTextInClipboard); + bool hasText = env->CallBooleanMethod(_jobj, _MID_hasTextInClipboard); if (env->ExceptionCheck()) { LOGE("Failed to check the contents of the clipboard"); @@ -299,13 +298,12 @@ Common::String JNI::getTextFromClipboard() { } bool JNI::setTextInClipboard(const Common::String &text) { - bool success = true; JNIEnv *env = JNI::getEnv(); jbyteArray javaText = env->NewByteArray(text.size()); env->SetByteArrayRegion(javaText, 0, text.size(), reinterpret_cast<const jbyte*>(text.c_str())); - success = env->CallBooleanMethod(_jobj, _MID_setTextInClipboard, javaText); + bool success = env->CallBooleanMethod(_jobj, _MID_setTextInClipboard, javaText); if (env->ExceptionCheck()) { LOGE("Failed to add text to the clipboard"); @@ -320,9 +318,8 @@ bool JNI::setTextInClipboard(const Common::String &text) { } bool JNI::isConnectionLimited() { - bool limited = false; JNIEnv *env = JNI::getEnv(); - limited = env->CallBooleanMethod(_jobj, _MID_isConnectionLimited); + bool limited = env->CallBooleanMethod(_jobj, _MID_isConnectionLimited); if (env->ExceptionCheck()) { LOGE("Failed to check whether connection's limited"); |