diff options
| author | Willem Jan Palenstijn | 2011-06-04 16:39:15 +0200 |
|---|---|---|
| committer | Willem Jan Palenstijn | 2011-06-04 16:39:39 +0200 |
| commit | 2d87394be97e7ed989fabfd0cfbbace204bd213d (patch) | |
| tree | f887aec89ca66e4cb92a23819fb6d1800c43e4be /backends/platform | |
| parent | 3f603ce0ab97ba9176d3e2df6cfab3de49d98d24 (diff) | |
| download | scummvm-rg350-2d87394be97e7ed989fabfd0cfbbace204bd213d.tar.gz scummvm-rg350-2d87394be97e7ed989fabfd0cfbbace204bd213d.tar.bz2 scummvm-rg350-2d87394be97e7ed989fabfd0cfbbace204bd213d.zip | |
POSIX: Add TODO/FIXME to displayLogFile
Diffstat (limited to 'backends/platform')
| -rw-r--r-- | backends/platform/sdl/posix/posix.cpp | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/backends/platform/sdl/posix/posix.cpp b/backends/platform/sdl/posix/posix.cpp index a45949deda..d757186134 100644 --- a/backends/platform/sdl/posix/posix.cpp +++ b/backends/platform/sdl/posix/posix.cpp @@ -167,6 +167,10 @@ bool OSystem_POSIX::displayLogFile() { execlp("xdg-open", "xdg-open", _logFilePath.c_str(), (char*)0); // If we're here, that clearly failed. + + // TODO: We may also want to try detecting the case where + // xdg-open is successfully executed but returns an error code. + // Try xterm+less next execlp("xterm", "xterm", "-e", "less", _logFilePath.c_str(), (char*)0); @@ -182,6 +186,9 @@ bool OSystem_POSIX::displayLogFile() { int status; // Wait for viewer to close. // (But note that xdg-open may have spawned a viewer in the background.) + + // FIXME: We probably want the viewer to always open in the background. + // This may require installing a SIGCHLD handler. pid = waitpid(pid, &status, 0); if (pid < 0) { |