aboutsummaryrefslogtreecommitdiff
path: root/backends/plugins
diff options
context:
space:
mode:
authorTony Puccinelli2010-08-05 20:54:48 +0000
committerTony Puccinelli2010-08-05 20:54:48 +0000
commitd1deaedc1a1e66ea34ca9544bc0e178dd24f48f9 (patch)
tree2c9bd80d4d80e7db397fddc87451c36689f434ad /backends/plugins
parentcade67be4f2d297b855628ff7ca0f2cd1c1efcc2 (diff)
downloadscummvm-rg350-d1deaedc1a1e66ea34ca9544bc0e178dd24f48f9.tar.gz
scummvm-rg350-d1deaedc1a1e66ea34ca9544bc0e178dd24f48f9.tar.bz2
scummvm-rg350-d1deaedc1a1e66ea34ca9544bc0e178dd24f48f9.zip
dealt with FIXME comments: removing superfluous checks, printfs, etc.
svn-id: r51765
Diffstat (limited to 'backends/plugins')
-rw-r--r--backends/plugins/elf-provider.cpp15
1 files changed, 2 insertions, 13 deletions
diff --git a/backends/plugins/elf-provider.cpp b/backends/plugins/elf-provider.cpp
index 76fa3cd6df..226ac06469 100644
--- a/backends/plugins/elf-provider.cpp
+++ b/backends/plugins/elf-provider.cpp
@@ -99,15 +99,9 @@ public:
void unloadPlugin() {
DynamicPlugin::unloadPlugin();
if (_dlHandle) {
- if (_dlHandle == NULL) {
- // FIXME: This check makes no sense, _dlHandle cannot be NULL at this point
- warning("Failed unloading plugin '%s' (Handle is NULL)", _filename.c_str());
- } else if (_dlHandle->close()) {
- delete _dlHandle;
- } else {
+ delete _dlHandle;
+ if (!_dlHandle->close()) {
warning("Failed unloading plugin '%s'", _filename.c_str());
- // FIXME: We are leaking _dlHandle here!
- // Any particular reasons why we would want to do that???
}
_dlHandle = 0;
}
@@ -121,15 +115,10 @@ Plugin* ELFPluginProvider::createPlugin(const Common::FSNode &node) const {
bool ELFPluginProvider::isPluginFilename(const Common::FSNode &node) const {
// Check the plugin suffix
- // FIXME: Do we need these printfs? Should get rid of them eventually.
Common::String filename = node.getName();
- printf("Testing name %s", filename.c_str());
if (!filename.hasSuffix(".PLG") && !filename.hasSuffix(".plg") && !filename.hasSuffix(".PLUGIN") && !filename.hasSuffix(".plugin")) {
- printf(" fail.\n");
return false;
}
-
- printf(" success!\n");
return true;
}