diff options
author | Willem Jan Palenstijn | 2013-04-18 23:35:23 +0200 |
---|---|---|
committer | Willem Jan Palenstijn | 2013-05-08 20:40:58 +0200 |
commit | 9c2341678ef4984bf92b3878295250faf980b066 (patch) | |
tree | 2fb4805e05e16b9924e80c9947e6bad723b28c4b /backends/timer/default | |
parent | 8172d679df5148a4a32f46074b20cb6caf91844f (diff) | |
parent | a5f4ff36ffc386d48f2da49387a9655ce9295a4d (diff) | |
download | scummvm-rg350-9c2341678ef4984bf92b3878295250faf980b066.tar.gz scummvm-rg350-9c2341678ef4984bf92b3878295250faf980b066.tar.bz2 scummvm-rg350-9c2341678ef4984bf92b3878295250faf980b066.zip |
Merge branch 'master'
Diffstat (limited to 'backends/timer/default')
-rw-r--r-- | backends/timer/default/default-timer.cpp | 8 |
1 files changed, 1 insertions, 7 deletions
diff --git a/backends/timer/default/default-timer.cpp b/backends/timer/default/default-timer.cpp index e1aadb62b8..8681102cd0 100644 --- a/backends/timer/default/default-timer.cpp +++ b/backends/timer/default/default-timer.cpp @@ -122,7 +122,7 @@ bool DefaultTimerManager::installTimerProc(TimerProc callback, int32 interval, v for (i = _callbacks.begin(); i != _callbacks.end(); ++i) { if (i->_value == callback) { - error("Same callback is referred by different names (%s vs %s)", i->_key.c_str(), id.c_str()); + error("Same callback added twice (old name: %s, new name: %s)", i->_key.c_str(), id.c_str()); } } _callbacks[id] = callback; @@ -136,12 +136,6 @@ bool DefaultTimerManager::installTimerProc(TimerProc callback, int32 interval, v slot->nextFireTimeMicro = interval % 1000; slot->next = 0; - // FIXME: It seems we do allow the client to add one callback multiple times over here, - // but "removeTimerProc" will remove *all* added instances. We should either prevent - // multiple additions of a timer proc OR we should change removeTimerProc to only remove - // a specific timer proc entry. - // Probably we can safely just allow a single addition of a specific function once - // and just update our Timer documentation accordingly. insertPrioQueue(_head, slot); return true; |