diff options
author | Johannes Schickel | 2009-08-22 00:41:22 +0000 |
---|---|---|
committer | Johannes Schickel | 2009-08-22 00:41:22 +0000 |
commit | cb56c27b9a2f3a4b3f0fb487cbc62205855062ea (patch) | |
tree | 5d8746267c59f5ebba67046f1066b451c37e7d9c /backends/timer | |
parent | 34223f8a9f6594b3268303637d937f2a64c0bda5 (diff) | |
download | scummvm-rg350-cb56c27b9a2f3a4b3f0fb487cbc62205855062ea.tar.gz scummvm-rg350-cb56c27b9a2f3a4b3f0fb487cbc62205855062ea.tar.bz2 scummvm-rg350-cb56c27b9a2f3a4b3f0fb487cbc62205855062ea.zip |
Add FIXME about DefaultTimerManager implementation.
svn-id: r43627
Diffstat (limited to 'backends/timer')
-rw-r--r-- | backends/timer/default/default-timer.cpp | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/backends/timer/default/default-timer.cpp b/backends/timer/default/default-timer.cpp index bd2222bbbc..dd468bbe09 100644 --- a/backends/timer/default/default-timer.cpp +++ b/backends/timer/default/default-timer.cpp @@ -124,6 +124,12 @@ bool DefaultTimerManager::installTimerProc(TimerProc callback, int32 interval, v slot->nextFireTimeMicro = interval % 1000; slot->next = 0; + // FIXME: It seems we do allow the client to add one callback multiple times over here, + // but "removeTimerProc" will remove *all* added instances. We should either prevent + // multiple additions of a timer proc OR we should change removeTimerProc to only remove + // a specific timer proc entry. + // Probably we can safely just allow a single addition of a specific function once + // and just update our Timer documentation accordingly. insertPrioQueue(_head, slot); return true; |