diff options
author | Max Horn | 2011-04-18 17:51:08 +0200 |
---|---|---|
committer | Max Horn | 2011-04-18 18:22:04 +0200 |
commit | 1037ed247042485df1ad312d9ddfbd17251ed907 (patch) | |
tree | 9df2de830f41c4d0c886ada1ad84b747a0e8e9bc /common | |
parent | cd2fcaf4ca338400ed8ee44566b9a767287efd69 (diff) | |
download | scummvm-rg350-1037ed247042485df1ad312d9ddfbd17251ed907.tar.gz scummvm-rg350-1037ed247042485df1ad312d9ddfbd17251ed907.tar.bz2 scummvm-rg350-1037ed247042485df1ad312d9ddfbd17251ed907.zip |
COMMON: Clarify error naming conventions
Not all error codes comply with these yet.
Diffstat (limited to 'common')
-rw-r--r-- | common/error.h | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/common/error.h b/common/error.h index f69ada9500..5c19761d6c 100644 --- a/common/error.h +++ b/common/error.h @@ -39,11 +39,10 @@ namespace Common { /** * Error codes which may be reported by plugins under various circumstances. * - * @todo Clarify the names; add more codes, resp. verify all existing ones are acutally useful. - * Also, try to avoid overlap. - * @todo Maybe introduce a naming convention? E.g. k-NOUN/ACTION-CONDITION-Error, so - * kPathInvalidError would be correct, but these would not be: kInvalidPath, - * kPathInvalid, kPathIsInvalid, kInvalidPathError + * @note Error names should follow the pattern k-NOUN/ACTION-CONDITION-Error. + * So kPathInvalidError would be correct, but these would not be: + * kInvalidPath, kPathInvalid, kPathIsInvalid, kInvalidPathError. + * @todo Adjust all error codes to comply with these conventions. */ enum ErrorCode { kNoError = 0, ///< No error occurred @@ -69,6 +68,7 @@ enum ErrorCode { kNoSavesError, ///< There are no saves to show kArgumentNotProcessed, ///< Used in command line parsing + kUnknownError ///< Catch-all error, used if no other error code matches }; |