Early in the morning, strrev() looks like a more difficult problem than it

really is. It's actually quite simple. In fact, the only magical thing about
Bob's version was the way it swapped variables without using any temporary
variable. Rewrote the function to use our SWAP() instead, since that actually
makes it readable. Moved it to util.cpp (outside the Common namespace, for
consistency with scumm_stricmp()) since Kirben knew of other places where it
could be used.

svn-id: r28231

1 files changed, 2 insertions, 17 deletions

diff --git a/engines/drascula/drascula.cpp b/engines/drascula/drascula.cpp
index f83e52f893..cff57d0ab5 100644
--- a/engines/drascula/drascula.cpp
+++ b/engines/drascula/drascula.cpp
@@ -18,7 +18,7 @@
  * along with this program; if not, write to the Free Software
  * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
  *
- * $UR$
+ * $URL$
  * $Id$
  *
  */
@@ -29,6 +29,7 @@
 #include "common/file.h"
 #include "common/savefile.h"
 #include "common/config-manager.h"
+//#include "common/util.h"
 
 #include "base/plugins.h"
 #include "base/version.h"
@@ -2080,22 +2081,6 @@ char DrasculaEngine::LimitaVGA(char valor) {
 	return (valor & 0x3F) * (valor > 0);
 }
 
-// Public domain strrev() function by Bob Stout.
-// Should perhaps be moved to common/util.cpp or similar.
-
-static char *scumm_strrev(char *str) {
-	char *p1, *p2;
-
-	if (!str || !*str)
-		return str;
-	for (p1 = str, p2 = str + strlen(str) - 1; p2 > p1; ++p1, --p2) {
-		*p1 ^= *p2;
-		*p2 ^= *p1;
-		*p1 ^= *p2;
-	}
-	return str;
-}
-
 void DrasculaEngine::centra_texto(char mensaje[], int x_texto, int y_texto) {
 	char bb[190], m2[190], m1[190] ,mb[10][40];
 	char m3[190];