diff options
| author | Colin Snover | 2017-10-01 00:56:01 -0500 |
|---|---|---|
| committer | Colin Snover | 2017-10-07 12:30:29 -0500 |
| commit | 432fd522d243f0779d2ebf99e8983dbb95cdd175 (patch) | |
| tree | 85532da09a21511230923eb8a4acc7ac15bda966 /engines/prince | |
| parent | ebe6c40a6abb2789349c2b6471eef24ac270ab94 (diff) | |
| download | scummvm-rg350-432fd522d243f0779d2ebf99e8983dbb95cdd175.tar.gz scummvm-rg350-432fd522d243f0779d2ebf99e8983dbb95cdd175.tar.bz2 scummvm-rg350-432fd522d243f0779d2ebf99e8983dbb95cdd175.zip | |
ENGINES: Remove default1x scaler flag
This flag is removed for a few reasons:
* Engines universally set this flag to true for widths > 320,
which made it redundant everywhere;
* This flag functioned primarily as a "force 1x scaler" flag,
since its behaviour was almost completely undocumented and users
would need to figure out that they'd need an explicit non-default
scaler set to get a scaler to operate at widths > 320;
* (Most importantly) engines should not be in the business of
deciding how the backend may choose to render its virtual screen.
The choice of rendering behaviour belongs to the user, and the
backend, in that order.
A nearby future commit restores the default1x scaler behaviour in
the SDL backend code for the moment, but in the future it is my
hope that there will be a better configuration UI to allow users
to specify how they want scaling to work for high resolutions.
Diffstat (limited to 'engines/prince')
| -rw-r--r-- | engines/prince/graphics.cpp | 2 | ||||
| -rw-r--r-- | engines/prince/videoplayer.cpp | 6 |
2 files changed, 4 insertions, 4 deletions
diff --git a/engines/prince/graphics.cpp b/engines/prince/graphics.cpp index 6be1782f1c..c25157c697 100644 --- a/engines/prince/graphics.cpp +++ b/engines/prince/graphics.cpp @@ -31,7 +31,7 @@ namespace Prince { GraphicsMan::GraphicsMan(PrinceEngine *vm) : _vm(vm), _changed(false) { - initGraphics(640, 480, true); + initGraphics(640, 480); _frontScreen = new Graphics::Surface(); _frontScreen->create(640, 480, Graphics::PixelFormat::createFormatCLUT8()); diff --git a/engines/prince/videoplayer.cpp b/engines/prince/videoplayer.cpp index 2fc9003be5..2e73c78a0d 100644 --- a/engines/prince/videoplayer.cpp +++ b/engines/prince/videoplayer.cpp @@ -30,7 +30,7 @@ namespace Prince { void PrinceEngine::playVideo(Common::String videoFilename) { // Set the correct video mode - initGraphics(640, 480, true, 0); + initGraphics(640, 480, nullptr); if (_system->getScreenFormat().bytesPerPixel == 1) { warning("Couldn't switch to a RGB color video mode to play a video."); return; @@ -42,7 +42,7 @@ void PrinceEngine::playVideo(Common::String videoFilename) { if (!videoDecoder->loadFile(videoFilename)) { delete videoDecoder; warning("Unable to open video %s", videoFilename.c_str()); - initGraphics(640, 480, true); + initGraphics(640, 480); return; } @@ -78,7 +78,7 @@ void PrinceEngine::playVideo(Common::String videoFilename) { delete videoDecoder; - initGraphics(640, 480, true); + initGraphics(640, 480); } } // End of namespace Prince |