diff options
| author | Johannes Schickel | 2016-02-09 02:51:42 +0100 |
|---|---|---|
| committer | Johannes Schickel | 2016-02-09 02:52:29 +0100 |
| commit | 01020089da07451336548dcaeb9365a3086911b8 (patch) | |
| tree | 1ca4b4ac0f7651bfb2a5429ca70b254332ae0a8f /engines/saga/music.cpp | |
| parent | a5b9df120d135a280a68eba1b2f5a88bca247724 (diff) | |
| download | scummvm-rg350-01020089da07451336548dcaeb9365a3086911b8.tar.gz scummvm-rg350-01020089da07451336548dcaeb9365a3086911b8.tar.bz2 scummvm-rg350-01020089da07451336548dcaeb9365a3086911b8.zip | |
SAGA: Add comments about possibly race conditions to timer callbacks.
(cherry picked from commit 93f627441ac68e7a4c3e7f748a7b6f999bd9c96a)
Diffstat (limited to 'engines/saga/music.cpp')
| -rw-r--r-- | engines/saga/music.cpp | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/engines/saga/music.cpp b/engines/saga/music.cpp index 663f5991d0..cd48ebaa4d 100644 --- a/engines/saga/music.cpp +++ b/engines/saga/music.cpp @@ -224,6 +224,9 @@ void Music::musicVolumeGaugeCallback(void *refCon) { } void Music::musicVolumeGauge() { + // CHECKME: This is potentially called from a different thread because it is + // called from a timer callback. However, it does not seem to take any + // precautions to avoid race conditions. int volume; _currentVolumePercent += 10; |