diff options
| author | sluicebox | 2018-10-28 10:49:15 -0700 |
|---|---|---|
| committer | Filippos Karapetis | 2018-10-28 19:49:15 +0200 |
| commit | bc8b97cf1c11836e0d2f47ba91837eb43f088f8d (patch) | |
| tree | 1080a480c7ba68c2696ccbbdb2f8de8b736726fb /engines/sci/engine | |
| parent | a48b2f3cfd0dc31f51112ab7814532b979d4645e (diff) | |
| download | scummvm-rg350-bc8b97cf1c11836e0d2f47ba91837eb43f088f8d.tar.gz scummvm-rg350-bc8b97cf1c11836e0d2f47ba91837eb43f088f8d.tar.bz2 scummvm-rg350-bc8b97cf1c11836e0d2f47ba91837eb43f088f8d.zip | |
SCI32: Remove GK1 French/Spanish CD SysLogger hotkey (#1366)
Removes a problematic active debug hotkey, bug #10781
Diffstat (limited to 'engines/sci/engine')
| -rw-r--r-- | engines/sci/engine/script_patches.cpp | 24 |
1 files changed, 24 insertions, 0 deletions
diff --git a/engines/sci/engine/script_patches.cpp b/engines/sci/engine/script_patches.cpp index bb1fd442fa..20d7763fb5 100644 --- a/engines/sci/engine/script_patches.cpp +++ b/engines/sci/engine/script_patches.cpp @@ -1669,8 +1669,32 @@ static const uint16 gk1DrugStoreEgoSpeedFixPatch[] = { PATCH_END }; +// French and Spanish CD versions contain an active debugging hotkey, ALT+N, +// which brings up a series of unskippable bug-reporting dialogs and +// eventually writes files to disk and crashes non-release builds due to +// an uninitialized read. This hotkey is always active and not hidden +// behind the game's debug mode flag so we just patch it out. +// +// Applies to: French and Spanish PC CD +// Responsible method: GK:handleEvent +// Fixes bug #10781 +static const uint16 gk1SysLoggerHotKeySignature[] = { + SIG_MAGICDWORD, + 0x34, SIG_UINT16(0x3100), // ldi 3100 [ ALT+N ] + 0x1a, // eq? + 0x31, // bnt + SIG_END +}; + +static const uint16 gk1SysLoggerHotKeyPatch[] = { + PATCH_ADDTOOFFSET(+4), + 0x33, // jmp + PATCH_END +}; + // script, description, signature patch static const SciScriptPatcherEntry gk1Signatures[] = { + { true, 0, "remove alt+n syslogger hotkey", 1, gk1SysLoggerHotKeySignature, gk1SysLoggerHotKeyPatch }, { true, 51, "fix interrogation bug", 1, gk1InterrogationBugSignature, gk1InterrogationBugPatch }, { true, 212, "fix day 5 drum book dialogue error", 1, gk1Day5DrumBookDialogueSignature, gk1Day5DrumBookDialoguePatch }, { true, 212, "fix day 5 phone softlock", 1, gk1Day5PhoneFreezeSignature, gk1Day5PhoneFreezePatch }, |