aboutsummaryrefslogtreecommitdiff
path: root/engines/sci/graphics/compare.cpp
diff options
context:
space:
mode:
authorMax Horn2010-02-05 22:55:41 +0000
committerMax Horn2010-02-05 22:55:41 +0000
commitd2871f925af38da89362b45edac43dbed5c925f5 (patch)
tree4cd3aef1e5011ece83d5ab3261ae0a7179c0797d /engines/sci/graphics/compare.cpp
parentf86618f92be1350bf6e56573c2419e604c811548 (diff)
downloadscummvm-rg350-d2871f925af38da89362b45edac43dbed5c925f5.tar.gz
scummvm-rg350-d2871f925af38da89362b45edac43dbed5c925f5.tar.bz2
scummvm-rg350-d2871f925af38da89362b45edac43dbed5c925f5.zip
SCI: Add comment to GfxCompare::canBeHereCheckRectList
svn-id: r47919
Diffstat (limited to 'engines/sci/graphics/compare.cpp')
-rw-r--r--engines/sci/graphics/compare.cpp5
1 files changed, 5 insertions, 0 deletions
diff --git a/engines/sci/graphics/compare.cpp b/engines/sci/graphics/compare.cpp
index f3d7e4b6cc..697324f975 100644
--- a/engines/sci/graphics/compare.cpp
+++ b/engines/sci/graphics/compare.cpp
@@ -93,6 +93,11 @@ bool GfxCompare::canBeHereCheckRectList(reg_t checkObject, Common::Rect checkRec
curRect.right = GET_SEL32V(_segMan, curObject, SELECTOR(brRight));
curRect.bottom = GET_SEL32V(_segMan, curObject, SELECTOR(brBottom));
// Check if curRect is within checkRect
+ // TODO: This check is slightly odd, because it means that a rect is not contained
+ // in itself. It may very well be that the original SCI engine did it just
+ // this way, so it should not be changed lightly. However, somebody should
+ // confirm whether the original engine really did it this way. Then, update
+ // this comment accordingly, and, if necessary, fix the code.
if (curRect.right > checkRect.left &&
curRect.left < checkRect.right &&
curRect.bottom > checkRect.top &&