diff options
author | athrxx | 2019-04-28 14:44:22 +0200 |
---|---|---|
committer | athrxx | 2019-06-21 13:35:35 +0200 |
commit | f35eae7287458a89c0ea24f66aa12795c4cb3956 (patch) | |
tree | b85cd1497d12c74f387fae1f0b7f78960399041a /engines/sci/sci.cpp | |
parent | 09f3d11cc18cc6c1bdf8a9de178e33de8e03ed96 (diff) | |
download | scummvm-rg350-f35eae7287458a89c0ea24f66aa12795c4cb3956.tar.gz scummvm-rg350-f35eae7287458a89c0ea24f66aa12795c4cb3956.tar.bz2 scummvm-rg350-f35eae7287458a89c0ea24f66aa12795c4cb3956.zip |
SCI: (CMS sound driver) - add support for SCI0
I haven't found an elegant and non-intrusive way to squeeze SCI0 support into LordHoto's existing code. The drivers are too different. So I made some rearrangements. The basic mechanisms of LordHoto's SCI1 code should remain the same as before, though. I only introduced some more classes, moved some code into these classes and renamed some things (mainly for myself, so as not to get confused).
I fixed two voice mapping bugs in the existing driver code. The first bug in bindVocies() effectively hindered the driver from playing anything at all when the CMS_DISABLE_VOICE_MAPPING #define wasn't set (_voice[i].channel == 0xFF instead of _voice[i].channel != 0xFF). The second bug in unbindVoices() was not a complete show stopper, but the function simply did not "unbind the voice". The line which does the actual removal of the channel assignment was missing.
The SCI0 driver portions have been tested with: PQ2, KQ4, LSL3, QFG1, ICE and COC.
SCI_0_EARLY versions apparently don't support the CMS. At least I haven't seen a driver file so far. And there seems to be no no instrument patch resource. Although the latter issue needn't necessarily be one, since the patch data array in the driver is actually preset with data (which gets overwritten as soon as a patch file is loaded). Maybe this would work for SCI_0_EARLY. However, I haven't tested this, since I really would have have a look at a driver file first if one actually exists. For now, I have limited the driver to SCI_0_LATE.
SCI1 has been tested with KQ5 and LSL5 (not extensively, just to see whether anything got broken and whether my voice mapping fixes work).
Diffstat (limited to 'engines/sci/sci.cpp')
0 files changed, 0 insertions, 0 deletions