diff options
author | Matthew Hoops | 2012-03-05 12:14:54 -0500 |
---|---|---|
committer | Matthew Hoops | 2012-03-05 12:22:13 -0500 |
commit | 865c54c125f0b5b0af1cd251cf07ec596dd4631a (patch) | |
tree | 8acefccc2ae40a805673da7f7b9f6640579d30ca /engines/sci | |
parent | dac35ac1cc2f94022ba3435b4231b9dd4ac8d60f (diff) | |
download | scummvm-rg350-865c54c125f0b5b0af1cd251cf07ec596dd4631a.tar.gz scummvm-rg350-865c54c125f0b5b0af1cd251cf07ec596dd4631a.tar.bz2 scummvm-rg350-865c54c125f0b5b0af1cd251cf07ec596dd4631a.zip |
SCI: Fix GK1 demo sounds
This is a regression from 9fd66deb43a8ba1bd7b423cb6fe2b7177af74166 and, despite the commit message, was *not* fixed by 1736345906af095c863a62ded2638ce92c2a0704
Diffstat (limited to 'engines/sci')
-rw-r--r-- | engines/sci/sound/soundcmd.cpp | 13 |
1 files changed, 6 insertions, 7 deletions
diff --git a/engines/sci/sound/soundcmd.cpp b/engines/sci/sound/soundcmd.cpp index 3306a76605..b8be898abc 100644 --- a/engines/sci/sound/soundcmd.cpp +++ b/engines/sci/sound/soundcmd.cpp @@ -39,15 +39,16 @@ SoundCommandParser::SoundCommandParser(ResourceManager *resMan, SegManager *segM #ifdef ENABLE_SFX_TYPE_SELECTION // Check if the user wants synthesized or digital sound effects in SCI1.1 - // or later games - _useDigitalSFX = ConfMan.getBool("multi_midi"); + // games based on the multi_midi config setting // In SCI2 and later games, this check should always be true - there was // always only one version of each sound effect or digital music track // (e.g. the menu music in GK1 - there is a sound effect with the same // resource number, but it's totally unrelated to the menu music). - if (getSciVersion() >= SCI_VERSION_2) - _useDigitalSFX = true; + // The GK1 demo (very late SCI1.1) does the same thing + // TODO: Check the QFG4 demo + + _useDigitalSFX = (getSciVersion() >= SCI_VERSION_2 || g_sci->getGameId() == GID_GK1 || ConfMan.getBool("multi_midi")); #else // Always prefer digital sound effects _useDigitalSFX = true; @@ -93,9 +94,7 @@ void SoundCommandParser::initSoundResource(MusicEntry *newSound) { // effects map) bool checkAudioResource = getSciVersion() >= SCI_VERSION_1_1; // Hoyle 4 has garbled audio resources in place of the sound resources. - // The demo of GK1 has no alternate sound effects. - if ((g_sci->getGameId() == GID_HOYLE4) || - (g_sci->getGameId() == GID_GK1 && g_sci->isDemo())) + if (g_sci->getGameId() == GID_HOYLE4) checkAudioResource = false; if (checkAudioResource && _resMan->testResource(ResourceId(kResourceTypeAudio, newSound->resourceId))) { |