diff options
author | Willem Jan Palenstijn | 2013-04-06 20:48:52 +0200 |
---|---|---|
committer | Willem Jan Palenstijn | 2013-04-06 20:48:52 +0200 |
commit | 173a022f91ffb888292ced1a8a4756db5eaca9b1 (patch) | |
tree | b6dfa4c40bf150b09efb35a10d0ddffd012a618d /engines | |
parent | d0d9894b22cbd0030ceee66c40f4d8f6bff7ff16 (diff) | |
download | scummvm-rg350-173a022f91ffb888292ced1a8a4756db5eaca9b1.tar.gz scummvm-rg350-173a022f91ffb888292ced1a8a4756db5eaca9b1.tar.bz2 scummvm-rg350-173a022f91ffb888292ced1a8a4756db5eaca9b1.zip |
SCI: Clarify comment
Diffstat (limited to 'engines')
-rw-r--r-- | engines/sci/sound/soundcmd.cpp | 8 |
1 files changed, 5 insertions, 3 deletions
diff --git a/engines/sci/sound/soundcmd.cpp b/engines/sci/sound/soundcmd.cpp index fb4564d859..f3375e7bb2 100644 --- a/engines/sci/sound/soundcmd.cpp +++ b/engines/sci/sound/soundcmd.cpp @@ -402,9 +402,11 @@ reg_t SoundCommandParser::kDoSoundFade(int argc, reg_t *argv, reg_t acc) { musicSlot->fadeStep = volume > musicSlot->fadeTo ? -5 : 5; musicSlot->fadeTickerStep = argv[2].toUint16() * 16667 / _music->soundGetTempo(); musicSlot->fadeTicker = 0; - // TODO: We handle this as a bit field (i.e. containing values 0 and 1), - // but some games pass other values here as well (e.g. some KQ6 scripts - // pass 3 here) + + // argv[4] is a boolean. Scripts sometimes pass strange values, + // but SSCI ignores these. (Verified in KQ6.) + // KQ6 room 460 even passes an object, but treating this as 'true' + // seems fine in that case. musicSlot->stopAfterFading = (argc == 5) ? (argv[4].toUint16() != 0) : false; break; |