diff options
author | Filippos Karapetis | 2010-08-20 09:35:20 +0000 |
---|---|---|
committer | Filippos Karapetis | 2010-08-20 09:35:20 +0000 |
commit | 31c889d7ce26c0386b39ee8664d05e87c53b8381 (patch) | |
tree | a569d0bcb820118240cfa906fd9dab9e2bcb7717 /engines | |
parent | 588472a8e69e2ecc98e3bf03c62bff029e715b81 (diff) | |
download | scummvm-rg350-31c889d7ce26c0386b39ee8664d05e87c53b8381.tar.gz scummvm-rg350-31c889d7ce26c0386b39ee8664d05e87c53b8381.tar.bz2 scummvm-rg350-31c889d7ce26c0386b39ee8664d05e87c53b8381.zip |
SCI: Fixed the GM detection introduced in rev #52211 to check the first available track, instead of track 1 (which doesn't always exist, e.g. in Pharkas). Also, added a comment inside applyPatch()
svn-id: r52222
Diffstat (limited to 'engines')
-rw-r--r-- | engines/sci/engine/script_patches.cpp | 1 | ||||
-rw-r--r-- | engines/sci/resource_audio.cpp | 10 |
2 files changed, 9 insertions, 2 deletions
diff --git a/engines/sci/engine/script_patches.cpp b/engines/sci/engine/script_patches.cpp index 6f97b3b69b..60d3369fb6 100644 --- a/engines/sci/engine/script_patches.cpp +++ b/engines/sci/engine/script_patches.cpp @@ -542,6 +542,7 @@ void Script::applyPatch(const uint16 *patch, byte *scriptData, const uint32 scri offset += patchWord & ~PATCH_ADDTOOFFSET; } else if (patchWord & PATCH_GETORIGINALBYTE) { // TODO: implement this + // Can be used to patch in some bytes from the original script into another location } else { scriptData[offset] = patchWord & 0xFF; offset++; diff --git a/engines/sci/resource_audio.cpp b/engines/sci/resource_audio.cpp index 5457c1eb38..590926dbbd 100644 --- a/engines/sci/resource_audio.cpp +++ b/engines/sci/resource_audio.cpp @@ -531,9 +531,15 @@ bool ResourceManager::isGMTrackIncluded() { // For the leftover games, we can safely use SCI_VERSION_1_EARLY for the soundVersion const SciVersion soundVersion = SCI_VERSION_1_EARLY; - // Read song 1 and check if it has a GM track + // Read the first song and check if it has a GM track bool result = false; - SoundResource *song1 = new SoundResource(1, this, soundVersion); + Common::List<ResourceId> *resources = listResources(kResourceTypeSound, -1); + Common::sort(resources->begin(), resources->end()); + Common::List<ResourceId>::iterator itr = resources->begin(); + int firstSongId = itr->getNumber(); + delete resources; + + SoundResource *song1 = new SoundResource(firstSongId, this, soundVersion); if (!song1) { warning("ResourceManager::isGMTrackIncluded: track 1 not found"); return false; |