SCI: Really Fix MSVC Warning

The Palette structure referred to here is in sci/graphics/helpers.h
not in the Graphics CursorMan class as previously thought.

Rather than adding a structure constructor which could have side
effects currently, the full structure is initialized here to avoid
the MSVC warning.

The previous change to CursorMan class Palette can be retained as it
is a reasonable code improvement in any case.

1 files changed, 8 insertions, 0 deletions

diff --git a/engines/sci/graphics/palette32.cpp b/engines/sci/graphics/palette32.cpp
index 7a3b396da8..803dc74044 100644
--- a/engines/sci/graphics/palette32.cpp
+++ b/engines/sci/graphics/palette32.cpp
@@ -108,12 +108,20 @@ const HunkPalette::EntryHeader HunkPalette::getEntryHeader() const {
 const Palette HunkPalette::toPalette() const {
 	Palette outPalette;
 
+	// Set outPalette structures to 0
+	for (int16 i = 0; i < ARRAYSIZE(outPalette.mapping); ++i) {
+		outPalette.mapping[i] = 0;
+	}
+	outPalette.timestamp = 0;
 	for (int16 i = 0; i < ARRAYSIZE(outPalette.colors); ++i) {
 		outPalette.colors[i].used = false;
 		outPalette.colors[i].r = 0;
 		outPalette.colors[i].g = 0;
 		outPalette.colors[i].b = 0;
 	}
+	for (int16 i = 0; i < ARRAYSIZE(outPalette.intensity); ++i) {
+		outPalette.intensity[i] = 0;
+	}
 
 	if (_numPalettes) {
 		const EntryHeader header = getEntryHeader();