aboutsummaryrefslogtreecommitdiff
path: root/engines
diff options
context:
space:
mode:
authorWillem Jan Palenstijn2013-06-18 18:46:54 +0200
committerWillem Jan Palenstijn2013-06-18 18:46:54 +0200
commit6e3510ac6154783a99b58bfae83c86145954435f (patch)
treeeeac831700cf3e73f68b779189617f19dbe2c006 /engines
parent7cc19bf29d391801fe8a720b36fce311fdcdd9a0 (diff)
downloadscummvm-rg350-6e3510ac6154783a99b58bfae83c86145954435f.tar.gz
scummvm-rg350-6e3510ac6154783a99b58bfae83c86145954435f.tar.bz2
scummvm-rg350-6e3510ac6154783a99b58bfae83c86145954435f.zip
SCI: Add note about LSL1vga DoSoundSendMidi
Diffstat (limited to 'engines')
-rw-r--r--engines/sci/sound/soundcmd.cpp7
1 files changed, 5 insertions, 2 deletions
diff --git a/engines/sci/sound/soundcmd.cpp b/engines/sci/sound/soundcmd.cpp
index daba976f50..9f3deca8ff 100644
--- a/engines/sci/sound/soundcmd.cpp
+++ b/engines/sci/sound/soundcmd.cpp
@@ -534,8 +534,11 @@ reg_t SoundCommandParser::kDoSoundSendMidi(int argc, reg_t *argv, reg_t acc) {
byte channel = argv[1].toUint16() & 0xf;
byte midiCmd = argv[2].toUint16() & 0xff;
- // TODO: first there is a 4-parameter variant of this call which needs to get reversed
- // second the current code isn't 100% accurate, sierra sci does checks on the 4th parameter
+ // TODO: There is a 4 parameter variant of this call,
+ // used by at least lsl1vga.
+ // It lacks a midiCmd argument, but for this variant midiCmd defaults to
+ // 0xB0 (controller). If argv[2] is 0xFF, midiCmd is 0xE0
+ // (pitchwheel). The exact parameters need to be investigated further.
if (argc == 4)
return acc;