aboutsummaryrefslogtreecommitdiff
path: root/engines
diff options
context:
space:
mode:
authorMax Horn2006-05-19 07:20:27 +0000
committerMax Horn2006-05-19 07:20:27 +0000
commit909cd8c93a9cf41617acfcbef7eda6704dc40dca (patch)
treeca9775c1175b2c60d0bb7ae33eb11a1954ea6b04 /engines
parentd113bf3a08595a07d6123273380a378120daf50f (diff)
downloadscummvm-rg350-909cd8c93a9cf41617acfcbef7eda6704dc40dca.tar.gz
scummvm-rg350-909cd8c93a9cf41617acfcbef7eda6704dc40dca.tar.bz2
scummvm-rg350-909cd8c93a9cf41617acfcbef7eda6704dc40dca.zip
Added some FIXMEs to the kyra engine
svn-id: r22531
Diffstat (limited to 'engines')
-rw-r--r--engines/kyra/kyra.cpp7
-rw-r--r--engines/kyra/kyra3.cpp1
2 files changed, 6 insertions, 2 deletions
diff --git a/engines/kyra/kyra.cpp b/engines/kyra/kyra.cpp
index 186faaacc4..aa72d887da 100644
--- a/engines/kyra/kyra.cpp
+++ b/engines/kyra/kyra.cpp
@@ -363,11 +363,12 @@ KyraEngine::~KyraEngine() {
}
KyraEngine_v1::~KyraEngine_v1() {
+ // FIXME: I am leaking badly!
}
KyraEngine_v2::~KyraEngine_v2() {
-
+ // FIXME: I am leaking badly!
}
void KyraEngine::errorString(const char *buf1, char *buf2) {
@@ -399,7 +400,7 @@ int KyraEngine::go() {
resetGameFlag(0xEF);
mainLoop();
}
- quitGame();
+ quitGame(); // FIXME: You shouldn't quit here, just return to the caller!
return 0;
}
@@ -546,6 +547,7 @@ void KyraEngine::mainLoop() {
}
void KyraEngine::quitGame() {
+ // FIXME: The code of this method should probably be moved to the destructor.
debugC(9, kDebugLevelMain, "KyraEngine::quitGame()");
for (int i = 0; i < ARRAYSIZE(_movieObjects); ++i) {
@@ -560,6 +562,7 @@ void KyraEngine::quitGame() {
Common::clearAllSpecialDebugLevels();
+ // FIXME: Do not use OSystem::quit() unless you have to !
_system->quit();
}
diff --git a/engines/kyra/kyra3.cpp b/engines/kyra/kyra3.cpp
index faa3ae1f22..7f357b24a5 100644
--- a/engines/kyra/kyra3.cpp
+++ b/engines/kyra/kyra3.cpp
@@ -36,6 +36,7 @@ KyraEngine_v3::KyraEngine_v3(OSystem *system) : KyraEngine(system) {
}
KyraEngine_v3::~KyraEngine_v3() {
+ delete _soundDigital;
}
Movie *KyraEngine_v3::createWSAMovie() {