diff options
| author | Filippos Karapetis | 2009-03-26 21:52:04 +0000 |
|---|---|---|
| committer | Filippos Karapetis | 2009-03-26 21:52:04 +0000 |
| commit | d75959c3540c21344d462c5074a1be55a984c588 (patch) | |
| tree | d51f31dbe8ab5c0f0f8ab3062514fde0af06fb12 /engines | |
| parent | 053b7b8a9b9105f5b94df485c74d537366caeff6 (diff) | |
| download | scummvm-rg350-d75959c3540c21344d462c5074a1be55a984c588.tar.gz scummvm-rg350-d75959c3540c21344d462c5074a1be55a984c588.tar.bz2 scummvm-rg350-d75959c3540c21344d462c5074a1be55a984c588.zip | |
Added a note about the potential invalid rectangles created when drawing lines
svn-id: r39704
Diffstat (limited to 'engines')
| -rw-r--r-- | engines/sci/engine/kgraphics.cpp | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/engines/sci/engine/kgraphics.cpp b/engines/sci/engine/kgraphics.cpp index 4ccd914023..58c4d68dbe 100644 --- a/engines/sci/engine/kgraphics.cpp +++ b/engines/sci/engine/kgraphics.cpp @@ -503,6 +503,11 @@ reg_t kGraph(EngineState *s, int funct_nr, int argc, reg_t *argv) { SKPV(2), SKPV(1), SKPV(4), SKPV(3), SKPV(5), SKPV_OR_ALT(6, -1), SKPV_OR_ALT(7, -1), gfxcolor.mask); redraw_port = 1; + + // Note: it's quite possible that the coordinates of the line will *not* form a valid rectangle (e.g. it might + // have negative width/height). The actual dirty rectangle is constructed in gfxdr_add_dirty(). + // FIXME/TODO: We need to change the semantics of this call, so that no fake rectangles are used. As it is, it's + // not possible change rect_t to Common::Rect, as we assume that Common::Rect forms a *valid* rectangle. ADD_TO_CURRENT_BG_WIDGETS(GFXW(gfxw_new_line(Common::Point(SKPV(2), SKPV(1)), Common::Point(SKPV(4), SKPV(3)), gfxcolor, GFX_LINE_MODE_CORRECT, GFX_LINE_STYLE_NORMAL))); |