aboutsummaryrefslogtreecommitdiff
path: root/graphics/fontman.cpp
diff options
context:
space:
mode:
authorJohannes Schickel2009-12-09 17:05:23 +0000
committerJohannes Schickel2009-12-09 17:05:23 +0000
commit0d43cc61d26e9cd68611c1c45cbf220b50e3b3f3 (patch)
tree202bde3591ef878186845a33ae5ad7e474f5d714 /graphics/fontman.cpp
parent8f34e4b11c77740ad9a8e316f30382e8ad9cd4dc (diff)
downloadscummvm-rg350-0d43cc61d26e9cd68611c1c45cbf220b50e3b3f3.tar.gz
scummvm-rg350-0d43cc61d26e9cd68611c1c45cbf220b50e3b3f3.tar.bz2
scummvm-rg350-0d43cc61d26e9cd68611c1c45cbf220b50e3b3f3.zip
Cleanup: remove "s_initialized" from CursorManager and FontManager implementation, these classes are Singletons, so they will ever only be initialized once at most anyway.
svn-id: r46313
Diffstat (limited to 'graphics/fontman.cpp')
-rw-r--r--graphics/fontman.cpp26
1 files changed, 14 insertions, 12 deletions
diff --git a/graphics/fontman.cpp b/graphics/fontman.cpp
index 05abb4e4c7..99c64ca976 100644
--- a/graphics/fontman.cpp
+++ b/graphics/fontman.cpp
@@ -29,30 +29,32 @@ DECLARE_SINGLETON(Graphics::FontManager);
namespace Graphics {
-const ScummFont *g_scummfont;
+const ScummFont *g_scummfont = 0;
extern const NewFont *g_sysfont;
extern const NewFont *g_sysfont_big;
extern const NewFont *g_consolefont;
-static bool s_initialized = false;
-
FontManager::FontManager() {
- if (!s_initialized) {
- // FIXME : this need to be freed
- s_initialized = true;
- g_scummfont = new ScummFont;
- INIT_FONT(g_sysfont)
- INIT_FONT(g_sysfont_big)
- INIT_FONT(g_consolefont)
- }
+ // This assert should *never* trigger, because
+ // FontManager is a singleton, thus there is only
+ // one instance of it per time. (g_scummfont gets
+ // reset to 0 in the desctructor of this class).
+ assert(g_scummfont == 0);
+ g_scummfont = new ScummFont;
+ INIT_FONT(g_sysfont)
+ INIT_FONT(g_sysfont_big)
+ INIT_FONT(g_consolefont)
}
FontManager::~FontManager() {
- s_initialized = false;
delete g_scummfont;
+ g_scummfont = 0;
delete g_sysfont;
+ g_sysfont = 0;
delete g_sysfont_big;
+ g_sysfont_big = 0;
delete g_consolefont;
+ g_consolefont = 0;
}
const Font *FontManager::getFontByName(const Common::String &name) const {