aboutsummaryrefslogtreecommitdiff
path: root/gui/module.mk
diff options
context:
space:
mode:
authorJohannes Schickel2016-01-07 11:21:56 +0100
committerJohannes Schickel2016-01-07 11:25:02 +0100
commit60fa9944dc8f942212ed0c3803aa690c3014c6a5 (patch)
tree12729715d221cca87979f6af49afa36a1004be05 /gui/module.mk
parent54f5c95832921b72583144e53fa45318a60e9ff9 (diff)
downloadscummvm-rg350-60fa9944dc8f942212ed0c3803aa690c3014c6a5.tar.gz
scummvm-rg350-60fa9944dc8f942212ed0c3803aa690c3014c6a5.tar.bz2
scummvm-rg350-60fa9944dc8f942212ed0c3803aa690c3014c6a5.zip
GUI: Explain create_project HACK in module.mk a bit better.
Diffstat (limited to 'gui/module.mk')
-rw-r--r--gui/module.mk13
1 files changed, 8 insertions, 5 deletions
diff --git a/gui/module.mk b/gui/module.mk
index fb7c968c34..bbb3def96d 100644
--- a/gui/module.mk
+++ b/gui/module.mk
@@ -32,11 +32,14 @@ MODULE_OBJS := \
widgets/scrollbar.o \
widgets/tab.o
-# HACK: Even if it seems redundant, please keep these directives in that order!
-# This is needed by the "create_project" tool, for the OS X / iOS Xcode project.
-# The main problem is that the create_project tool scans the files for both OS X, and iOS targets.
-# It must be able to collect all the files for both targets, so that the backend can later filter
-# them for its own targets (in the Xcode terminology)
+# HACK: create_project's XCode generator relies on the following ifdef
+# structure to pick up the right browser implementations for iOS and Mac OS X.
+# Please keep it like this or XCode project generation will be broken.
+# FIXME: This only works because of a bug in how we handle ifdef statements in
+# create_project's module.mk parser. create_project will think that both
+# browser.o and browser_osx.o is built when both IPHONE and MACOSX is set.
+# When we do proper ifdef handling, only browser.o will be picked up, breaking
+# XCode generation.
ifdef IPHONE
MODULE_OBJS += \
browser.o