diff options
author | Colin Snover | 2017-09-05 22:30:01 -0500 |
---|---|---|
committer | Colin Snover | 2017-09-12 11:27:45 -0500 |
commit | eb4e9fe1d48bee1c9f641b019a29642780604b30 (patch) | |
tree | df6495b8257c69c12759d0ad281c63b974f23925 /gui/themes | |
parent | c2a4784706502b21cde005979851f80d65698622 (diff) | |
download | scummvm-rg350-eb4e9fe1d48bee1c9f641b019a29642780604b30.tar.gz scummvm-rg350-eb4e9fe1d48bee1c9f641b019a29642780604b30.tar.bz2 scummvm-rg350-eb4e9fe1d48bee1c9f641b019a29642780604b30.zip |
GUI: Remove mostly-broken audio output sample rate control
Removing this GUI control was suggested as far back as 2011 at
<http://lists.scummvm.org/pipermail/scummvm-devel/2011-November/010416.html>.
There were no objections, but it was never removed. When working
on audio latency bugs, I independently rediscovered that the GUI
option was broken: the per-game options would *never* work, and the
option would not take effect until ScummVM was restarted because
there is no API for interacting with the backend audio mixer. So
now, it is finally gone.
Primarily for the sake of future troubleshooting, configurability
of the audio sample frequency within SdlMixerManager is maintained
for the moment, but now users will need to edit their ScummVM
configuration file manually to change it.
Diffstat (limited to 'gui/themes')
-rw-r--r-- | gui/themes/default.inc | 16 | ||||
-rw-r--r-- | gui/themes/scummclassic.zip | bin | 129631 -> 129144 bytes | |||
-rw-r--r-- | gui/themes/scummclassic/classic_layout.stx | 8 | ||||
-rw-r--r-- | gui/themes/scummclassic/classic_layout_lowres.stx | 8 | ||||
-rw-r--r-- | gui/themes/scummmodern.zip | bin | 1649171 -> 1648684 bytes | |||
-rw-r--r-- | gui/themes/scummmodern/scummmodern_layout.stx | 8 | ||||
-rw-r--r-- | gui/themes/scummmodern/scummmodern_layout_lowres.stx | 8 |
7 files changed, 0 insertions, 48 deletions
diff --git a/gui/themes/default.inc b/gui/themes/default.inc index 23488a8cd0..fe48acd1a0 100644 --- a/gui/themes/default.inc +++ b/gui/themes/default.inc @@ -907,14 +907,6 @@ const char *defaultXML1 = "<?xml version = '1.0'?>" "type='PopUp' " "/>" "</layout>" -"<layout type='horizontal' padding='0,0,0,0' spacing='10' center='true'>" -"<widget name='auSampleRatePopupDesc' " -"type='OptionsLabel' " -"/>" -"<widget name='auSampleRatePopup' " -"type='PopUp' " -"/>" -"</layout>" "<layout type='horizontal' padding='0,0,0,0' spacing='10'>" "<widget name='subToggleDesc' " "type='OptionsLabel' " @@ -2496,14 +2488,6 @@ const char *defaultXML1 = "<?xml version = '1.0'?>" "type='PopUp' " "/>" "</layout>" -"<layout type='horizontal' padding='0,0,0,0' spacing='6' center='true'>" -"<widget name='auSampleRatePopupDesc' " -"type='OptionsLabel' " -"/>" -"<widget name='auSampleRatePopup' " -"type='PopUp' " -"/>" -"</layout>" "<layout type='horizontal' padding='0,0,0,0' spacing='3' center='true'>" "<widget name='subToggleDesc' " "type='OptionsLabel' " diff --git a/gui/themes/scummclassic.zip b/gui/themes/scummclassic.zip Binary files differindex acb6d20a99..4f7e3ce68d 100644 --- a/gui/themes/scummclassic.zip +++ b/gui/themes/scummclassic.zip diff --git a/gui/themes/scummclassic/classic_layout.stx b/gui/themes/scummclassic/classic_layout.stx index 2bb07d914c..e3411dcb3e 100644 --- a/gui/themes/scummclassic/classic_layout.stx +++ b/gui/themes/scummclassic/classic_layout.stx @@ -335,14 +335,6 @@ type = 'PopUp' /> </layout> - <layout type = 'horizontal' padding = '0, 0, 0, 0' spacing = '10' center = 'true'> - <widget name = 'auSampleRatePopupDesc' - type = 'OptionsLabel' - /> - <widget name = 'auSampleRatePopup' - type = 'PopUp' - /> - </layout> <layout type = 'horizontal' padding = '0, 0, 0, 0' spacing = '10'> <widget name = 'subToggleDesc' type = 'OptionsLabel' diff --git a/gui/themes/scummclassic/classic_layout_lowres.stx b/gui/themes/scummclassic/classic_layout_lowres.stx index d0c3170d8e..4b710b8999 100644 --- a/gui/themes/scummclassic/classic_layout_lowres.stx +++ b/gui/themes/scummclassic/classic_layout_lowres.stx @@ -332,14 +332,6 @@ type = 'PopUp' /> </layout> - <layout type = 'horizontal' padding = '0, 0, 0, 0' spacing = '6' center = 'true'> - <widget name = 'auSampleRatePopupDesc' - type = 'OptionsLabel' - /> - <widget name = 'auSampleRatePopup' - type = 'PopUp' - /> - </layout> <layout type = 'horizontal' padding = '0, 0, 0, 0' spacing = '3' center = 'true'> <widget name = 'subToggleDesc' type = 'OptionsLabel' diff --git a/gui/themes/scummmodern.zip b/gui/themes/scummmodern.zip Binary files differindex 055c82ad3c..fae746b72c 100644 --- a/gui/themes/scummmodern.zip +++ b/gui/themes/scummmodern.zip diff --git a/gui/themes/scummmodern/scummmodern_layout.stx b/gui/themes/scummmodern/scummmodern_layout.stx index 0a1c377aea..34b66e2274 100644 --- a/gui/themes/scummmodern/scummmodern_layout.stx +++ b/gui/themes/scummmodern/scummmodern_layout.stx @@ -349,14 +349,6 @@ type = 'PopUp' /> </layout> - <layout type = 'horizontal' padding = '0, 0, 0, 0' spacing = '10' center = 'true'> - <widget name = 'auSampleRatePopupDesc' - type = 'OptionsLabel' - /> - <widget name = 'auSampleRatePopup' - type = 'PopUp' - /> - </layout> <layout type = 'horizontal' padding = '0, 0, 0, 0' spacing = '10'> <widget name = 'subToggleDesc' type = 'OptionsLabel' diff --git a/gui/themes/scummmodern/scummmodern_layout_lowres.stx b/gui/themes/scummmodern/scummmodern_layout_lowres.stx index 3da8a6c6a3..506a97520e 100644 --- a/gui/themes/scummmodern/scummmodern_layout_lowres.stx +++ b/gui/themes/scummmodern/scummmodern_layout_lowres.stx @@ -330,14 +330,6 @@ type = 'PopUp' /> </layout> - <layout type = 'horizontal' padding = '0, 0, 0, 0' spacing = '6' center = 'true'> - <widget name = 'auSampleRatePopupDesc' - type = 'OptionsLabel' - /> - <widget name = 'auSampleRatePopup' - type = 'PopUp' - /> - </layout> <layout type = 'horizontal' padding = '0, 0, 0, 0' spacing = '3' center = 'true'> <widget name = 'subToggleDesc' type = 'OptionsLabel' |