diff options
| author | Johannes Schickel | 2011-10-23 20:02:35 +0200 |
|---|---|---|
| committer | Johannes Schickel | 2011-10-23 20:04:03 +0200 |
| commit | 3a196478c69b635c7c1c2d121b30d9710f8bd1e5 (patch) | |
| tree | 2fdf78e3a0b0756279164b9f7abc683c13cab619 /gui | |
| parent | a41d72a44a660c72fdadbc3a8ef580e5e03cb890 (diff) | |
| download | scummvm-rg350-3a196478c69b635c7c1c2d121b30d9710f8bd1e5.tar.gz scummvm-rg350-3a196478c69b635c7c1c2d121b30d9710f8bd1e5.tar.bz2 scummvm-rg350-3a196478c69b635c7c1c2d121b30d9710f8bd1e5.zip | |
ALL: Reduce assignment of "" to Common::String.
When clearing an existant object clear() should be used.
When constructing objects (or using default values for parameters) the
constructor of String without any argument should be used.
This changes only a few instances I noticed while looking over some recent
commit logs.
Diffstat (limited to 'gui')
| -rw-r--r-- | gui/options.cpp | 4 | ||||
| -rw-r--r-- | gui/saveload.cpp | 2 |
2 files changed, 3 insertions, 3 deletions
diff --git a/gui/options.cpp b/gui/options.cpp index 67204fc343..ad2e3d92d0 100644 --- a/gui/options.cpp +++ b/gui/options.cpp @@ -141,7 +141,7 @@ void OptionsDialog::init() { _oldTheme = g_gui.theme()->getThemeId(); // Retrieve game GUI options - _guioptions = ""; + _guioptions.clear(); if (ConfMan.hasKey("guioptions", _domain)) { _guioptionsString = ConfMan.get("guioptions", _domain); _guioptions = parseGameGUIOptions(_guioptionsString); @@ -155,7 +155,7 @@ void OptionsDialog::open() { setResult(0); // Retrieve game GUI options - _guioptions = ""; + _guioptions.clear(); if (ConfMan.hasKey("guioptions", _domain)) { _guioptionsString = ConfMan.get("guioptions", _domain); _guioptions = parseGameGUIOptions(_guioptionsString); diff --git a/gui/saveload.cpp b/gui/saveload.cpp index ae950a21fb..3dc9961906 100644 --- a/gui/saveload.cpp +++ b/gui/saveload.cpp @@ -92,7 +92,7 @@ int SaveLoadChooser::runModalWithPluginAndTarget(const EnginePlugin *plugin, con _thumbnailSupport = _metaInfoSupport && (*_plugin)->hasFeature(MetaEngine::kSavesSupportThumbnail); _saveDateSupport = _metaInfoSupport && (*_plugin)->hasFeature(MetaEngine::kSavesSupportCreationDate); _playTimeSupport = _metaInfoSupport && (*_plugin)->hasFeature(MetaEngine::kSavesSupportPlayTime); - _resultString = ""; + _resultString.clear(); reflowLayout(); updateSaveList(); |