diff options
| author | Johannes Schickel | 2009-08-18 15:32:26 +0000 |
|---|---|---|
| committer | Johannes Schickel | 2009-08-18 15:32:26 +0000 |
| commit | 5c11ec51bc0e246615874876c913371672a725a3 (patch) | |
| tree | 62190d12304420b2217e5fea7e883127ccb90413 /sound/audiocd.h | |
| parent | b33b90ecd0468c58b93e13ff80bf6939e97ed7a6 (diff) | |
| download | scummvm-rg350-5c11ec51bc0e246615874876c913371672a725a3.tar.gz scummvm-rg350-5c11ec51bc0e246615874876c913371672a725a3.tar.bz2 scummvm-rg350-5c11ec51bc0e246615874876c913371672a725a3.zip | |
- Destory AudioCDManager singleton after user quits a game, this saves a few bytes memory
- Added FIXME to audiocd.h, concering why destroying the AudioCDManager can not quit CD playback right now
svn-id: r43513
Diffstat (limited to 'sound/audiocd.h')
| -rw-r--r-- | sound/audiocd.h | 8 |
1 files changed, 8 insertions, 0 deletions
diff --git a/sound/audiocd.h b/sound/audiocd.h index 4c4ff26147..2dc379ca27 100644 --- a/sound/audiocd.h +++ b/sound/audiocd.h @@ -67,6 +67,14 @@ private: friend class Common::Singleton<SingletonBaseType>; AudioCDManager(); + // FIXME: It might make sense to stop CD playback, when the AudioCDManager singleton + // is destroyed. Currently we can not do this, since in worst case the OSystem and + // along wiht it the Mixer will be destroyed before the AudioCDManager, thus + // leading to invalid memory access. If we can fix up the code to destroy the + // AudioCDManager before OSystem in *all* cases, that is including calling + // OSystem::quit, we might be able to implement it via a simple "stop()" + // call in a custom destructor of AudioCDManager. + /* used for emulated CD music */ SoundHandle _handle; bool _emulating; |